* [PATCH] omap2-clk: Add missing lcdc clock definition
@ 2012-10-31 15:56 Pantelis Antoniou
2012-10-30 18:18 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Pantelis Antoniou @ 2012-10-31 15:56 UTC (permalink / raw)
To: Paul Walmsley
Cc: Pantelis Antoniou, Tony Lindgren, linux-omap, linux-kernel,
Koen Kooi, Matt Porter, Russ Dill
Looks like the lcdc clock definition got dropped.
It is required for the LCD controller to work. Reintroduce.
Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
arch/arm/mach-omap2/clock33xx_data.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/mach-omap2/clock33xx_data.c b/arch/arm/mach-omap2/clock33xx_data.c
index 1a45d6b..b7b7995 100644
--- a/arch/arm/mach-omap2/clock33xx_data.c
+++ b/arch/arm/mach-omap2/clock33xx_data.c
@@ -867,6 +867,16 @@ static struct clk lcd_gclk = {
.recalc = &followparent_recalc,
};
+static struct clk lcdc_fck = {
+ .name = "lcdc_fck",
+ .clkdm_name = "lcdc_clkdm",
+ .parent = &lcd_gclk,
+ .enable_reg = AM33XX_CM_PER_LCDC_CLKCTRL,
+ .enable_bit = AM33XX_MODULEMODE_SWCTRL,
+ .ops = &clkops_omap2_dflt,
+ .recalc = &followparent_recalc,
+};
+
static struct clk mmc_clk = {
.name = "mmc_clk",
.clkdm_name = "l4ls_clkdm",
@@ -1075,6 +1085,7 @@ static struct omap_clk am33xx_clks[] = {
CLK(NULL, "clkout2_ck", &clkout2_ck, CK_AM33XX),
CLK(NULL, "timer_32k_ck", &clkdiv32k_ick, CK_AM33XX),
CLK(NULL, "timer_sys_ck", &sys_clkin_ck, CK_AM33XX),
+ CLK("da8xx_lcdc.0", NULL, &lcdc_fck, CK_AM33XX),
};
int __init am33xx_clk_init(void)
--
1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] omap2-clk: Add missing lcdc clock definition
2012-10-31 15:56 [PATCH] omap2-clk: Add missing lcdc clock definition Pantelis Antoniou
@ 2012-10-30 18:18 ` Tony Lindgren
2012-10-30 23:26 ` Paul Walmsley
0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2012-10-30 18:18 UTC (permalink / raw)
To: Pantelis Antoniou
Cc: Paul Walmsley, linux-omap, linux-kernel, Koen Kooi, Matt Porter,
Russ Dill
* Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:04]:
> Looks like the lcdc clock definition got dropped.
> It is required for the LCD controller to work. Reintroduce.
This looks like a regression, can you also add the commit
causing it?
Regards,
Tony
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> arch/arm/mach-omap2/clock33xx_data.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/clock33xx_data.c b/arch/arm/mach-omap2/clock33xx_data.c
> index 1a45d6b..b7b7995 100644
> --- a/arch/arm/mach-omap2/clock33xx_data.c
> +++ b/arch/arm/mach-omap2/clock33xx_data.c
> @@ -867,6 +867,16 @@ static struct clk lcd_gclk = {
> .recalc = &followparent_recalc,
> };
>
> +static struct clk lcdc_fck = {
> + .name = "lcdc_fck",
> + .clkdm_name = "lcdc_clkdm",
> + .parent = &lcd_gclk,
> + .enable_reg = AM33XX_CM_PER_LCDC_CLKCTRL,
> + .enable_bit = AM33XX_MODULEMODE_SWCTRL,
> + .ops = &clkops_omap2_dflt,
> + .recalc = &followparent_recalc,
> +};
> +
> static struct clk mmc_clk = {
> .name = "mmc_clk",
> .clkdm_name = "l4ls_clkdm",
> @@ -1075,6 +1085,7 @@ static struct omap_clk am33xx_clks[] = {
> CLK(NULL, "clkout2_ck", &clkout2_ck, CK_AM33XX),
> CLK(NULL, "timer_32k_ck", &clkdiv32k_ick, CK_AM33XX),
> CLK(NULL, "timer_sys_ck", &sys_clkin_ck, CK_AM33XX),
> + CLK("da8xx_lcdc.0", NULL, &lcdc_fck, CK_AM33XX),
> };
>
> int __init am33xx_clk_init(void)
> --
> 1.7.12
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] omap2-clk: Add missing lcdc clock definition
2012-10-30 18:18 ` Tony Lindgren
@ 2012-10-30 23:26 ` Paul Walmsley
2012-10-31 5:09 ` Hiremath, Vaibhav
0 siblings, 1 reply; 6+ messages in thread
From: Paul Walmsley @ 2012-10-30 23:26 UTC (permalink / raw)
To: Tony Lindgren
Cc: Pantelis Antoniou, linux-omap, linux-kernel, Koen Kooi,
Matt Porter, Russ Dill, hvaibhav
+ Vaibhav Hiremath
On Tue, 30 Oct 2012, Tony Lindgren wrote:
> * Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:04]:
> > Looks like the lcdc clock definition got dropped.
> > It is required for the LCD controller to work. Reintroduce.
>
> This looks like a regression, can you also add the commit
> causing it?
Looks like probably a new "feature," in that this clock didn't exist in
the original check-in. Would be good to get Vaibhav's opinion on this;
also the common clock patches will need to be updated.
- Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] omap2-clk: Add missing lcdc clock definition
2012-10-30 23:26 ` Paul Walmsley
@ 2012-10-31 5:09 ` Hiremath, Vaibhav
2012-10-31 5:49 ` Paul Walmsley
0 siblings, 1 reply; 6+ messages in thread
From: Hiremath, Vaibhav @ 2012-10-31 5:09 UTC (permalink / raw)
To: Paul Walmsley, Tony Lindgren
Cc: Pantelis Antoniou, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, Koen Kooi, Porter, Matt, Dill, Russ,
linux-fbdev@vger.kernel.org
On Wed, Oct 31, 2012 at 04:56:40, Paul Walmsley wrote:
> + Vaibhav Hiremath
>
> On Tue, 30 Oct 2012, Tony Lindgren wrote:
>
> > * Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:04]:
> > > Looks like the lcdc clock definition got dropped.
> > > It is required for the LCD controller to work. Reintroduce.
> >
> > This looks like a regression, can you also add the commit
> > causing it?
>
> Looks like probably a new "feature," in that this clock didn't exist in
> the original check-in. Would be good to get Vaibhav's opinion on this;
> also the common clock patches will need to be updated.
>
Thanks Paul for looping me in, something went wrong with my l-o subscription,
so I didn't receive these Patches.
As far as lck clock node is concerned, we had deliberately dropped all leaf-
node clocks from the clock tree, please refer to the description mentioned
in -
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101987.html
>From LCDC driver perspective, driver is using,
fb_clk = clk_get(&device->dev, NULL);
This I feel needs to be corrected for valid name as per Spec (mostly I would
vote for "fck") and then every platform should make sure that it returns
valid clock-node for it.
Change in Driver would be,
fb_clk = clk_get(&device->dev, "fck");
Thanks,
Vaibhav
>
> - Paul
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] omap2-clk: Add missing lcdc clock definition
2012-10-31 5:09 ` Hiremath, Vaibhav
@ 2012-10-31 5:49 ` Paul Walmsley
2012-10-31 6:38 ` Hiremath, Vaibhav
0 siblings, 1 reply; 6+ messages in thread
From: Paul Walmsley @ 2012-10-31 5:49 UTC (permalink / raw)
To: Hiremath, Vaibhav
Cc: Tony Lindgren, Pantelis Antoniou, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, Koen Kooi, Porter, Matt, Dill, Russ,
linux-fbdev@vger.kernel.org
On Wed, 31 Oct 2012, Hiremath, Vaibhav wrote:
> As far as lck clock node is concerned, we had deliberately dropped all leaf-
> node clocks from the clock tree, please refer to the description mentioned
> in -
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101987.html
Ach, should have remembered that :-( Indeed there is an LCDC hwmod:
static struct omap_hwmod am33xx_lcdc_hwmod = {
.name = "lcdc",
.class = &am33xx_lcdc_hwmod_class,
.clkdm_name = "lcdc_clkdm",
.mpu_irqs = am33xx_lcdc_irqs,
.flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY,
.main_clk = "lcd_gclk",
.prcm = {
.omap4 = {
.clkctrl_offs = AM33XX_CM_PER_LCDC_CLKCTRL_OFFSET,
.modulemode = MODULEMODE_SWCTRL,
},
},
};
> >From LCDC driver perspective, driver is using,
>
> fb_clk = clk_get(&device->dev, NULL);
>
> This I feel needs to be corrected for valid name as per Spec (mostly I would
> vote for "fck") and then every platform should make sure that it returns
> valid clock-node for it.
>
> Change in Driver would be,
>
> fb_clk = clk_get(&device->dev, "fck");
Indeed.
- Paul
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] omap2-clk: Add missing lcdc clock definition
2012-10-31 5:49 ` Paul Walmsley
@ 2012-10-31 6:38 ` Hiremath, Vaibhav
0 siblings, 0 replies; 6+ messages in thread
From: Hiremath, Vaibhav @ 2012-10-31 6:38 UTC (permalink / raw)
To: Paul Walmsley
Cc: Tony Lindgren, Pantelis Antoniou, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, Koen Kooi, Porter, Matt, Dill, Russ,
linux-fbdev@vger.kernel.org
On Wed, Oct 31, 2012 at 11:19:44, Paul Walmsley wrote:
> On Wed, 31 Oct 2012, Hiremath, Vaibhav wrote:
>
> > As far as lck clock node is concerned, we had deliberately dropped all leaf-
> > node clocks from the clock tree, please refer to the description mentioned
> > in -
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101987.html
>
> Ach, should have remembered that :-( Indeed there is an LCDC hwmod:
>
> static struct omap_hwmod am33xx_lcdc_hwmod = {
> .name = "lcdc",
> .class = &am33xx_lcdc_hwmod_class,
> .clkdm_name = "lcdc_clkdm",
> .mpu_irqs = am33xx_lcdc_irqs,
> .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY,
> .main_clk = "lcd_gclk",
> .prcm = {
> .omap4 = {
> .clkctrl_offs = AM33XX_CM_PER_LCDC_CLKCTRL_OFFSET,
> .modulemode = MODULEMODE_SWCTRL,
> },
> },
> };
>
> > >From LCDC driver perspective, driver is using,
> >
> > fb_clk = clk_get(&device->dev, NULL);
> >
> > This I feel needs to be corrected for valid name as per Spec (mostly I would
> > vote for "fck") and then every platform should make sure that it returns
> > valid clock-node for it.
> >
> > Change in Driver would be,
> >
> > fb_clk = clk_get(&device->dev, "fck");
>
Ok, thanks. Let me submit patch for this.
Thanks,
Vaibhav
> Indeed.
>
>
> - Paul
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-31 6:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-31 15:56 [PATCH] omap2-clk: Add missing lcdc clock definition Pantelis Antoniou
2012-10-30 18:18 ` Tony Lindgren
2012-10-30 23:26 ` Paul Walmsley
2012-10-31 5:09 ` Hiremath, Vaibhav
2012-10-31 5:49 ` Paul Walmsley
2012-10-31 6:38 ` Hiremath, Vaibhav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).