From: Tony Lindgren <tony@atomide.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: linux-kernel@vger.kernel.org,
Koen Kooi <koen@dominion.thruhere.net>,
Matt Porter <mporter@ti.com>, Russ Dill <Russ.Dill@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2
Date: Wed, 31 Oct 2012 10:52:19 -0700 [thread overview]
Message-ID: <20121031175219.GH12739@atomide.com> (raw)
In-Reply-To: <1351783082-11411-1-git-send-email-panto@antoniou-consulting.com>
* Pantelis Antoniou <panto@antoniou-consulting.com> [121031 10:26]:
> It is painless to move the adapter DT devices to arch/arm/mach-omap2
>
> However I got bit by the __init at omap_build_device family functions.
> If you don't remove it, crashes every time you instantiate a device
> at runtime, or you load the cape driver as a module.
Hmm I think you misunderstood me. You only need to create the
platform_device under arch/arm/mach-omap2. The device creation
happens only at __init, so omap_build_device can stay as __init.
The driver itself should be under drivers.
But is this bus on non-device-tree omaps? If not, just make it
device tree only.
Regards,
Tony
next prev parent reply other threads:[~2012-10-31 17:52 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 15:17 [PATCH 0/3] capebus moving omap_devices to mach-omap2 Pantelis Antoniou
2012-10-31 17:52 ` Tony Lindgren [this message]
2012-10-31 18:04 ` Pantelis Antoniou
2012-10-31 18:09 ` Tony Lindgren
2012-10-31 18:24 ` Pantelis Antoniou
2012-10-31 19:55 ` Benoit Cousson
2012-10-31 20:12 ` Pantelis Antoniou
2012-10-31 21:26 ` Tony Lindgren
2012-10-31 21:36 ` Pantelis Antoniou
2012-10-31 21:43 ` Tony Lindgren
2012-10-31 22:00 ` Pantelis Antoniou
2012-10-31 22:16 ` Tony Lindgren
2012-10-31 22:14 ` Felipe Balbi
2012-11-01 7:02 ` Pantelis Antoniou
2012-11-01 10:23 ` Cousson, Benoit
2012-11-01 10:39 ` Pantelis Antoniou
2012-11-01 11:04 ` Felipe Balbi
2012-11-01 11:26 ` Pantelis Antoniou
2012-11-01 12:40 ` Felipe Balbi
2012-11-01 12:57 ` Pantelis Antoniou
2012-11-01 13:16 ` Felipe Balbi
2012-11-01 13:35 ` Pantelis Antoniou
2012-11-01 13:51 ` Alan Cox
2012-11-01 13:59 ` Pantelis Antoniou
2012-11-01 22:05 ` Felipe Balbi
2012-11-01 23:49 ` Russ Dill
2012-11-02 8:57 ` Felipe Balbi
2012-11-02 9:42 ` Russ Dill
2012-11-02 10:39 ` Koen Kooi
2012-11-02 11:00 ` Felipe Balbi
2012-11-02 16:44 ` Russ Dill
2012-11-02 11:21 ` Alan Cox
2012-11-02 12:32 ` Pantelis Antoniou
2012-11-05 0:37 ` Grant Likely
2012-11-05 15:37 ` Pantelis Antoniou
2012-11-05 19:10 ` Grant Likely
2012-11-05 19:54 ` Pantelis Antoniou
2012-11-05 20:14 ` Grant Likely
2012-11-05 22:59 ` Joel A Fernandes
2012-11-05 23:58 ` Grant Likely
2012-11-06 3:06 ` Joel A Fernandes
2012-11-06 8:14 ` Pantelis Antoniou
2012-11-06 11:16 ` Grant Likely
2012-11-06 13:54 ` Pantelis Antoniou
2012-11-02 16:07 ` Jason Kridner
2012-11-02 16:28 ` Alan Cox
2012-11-05 1:05 ` Grant Likely
2012-11-01 11:26 ` Cousson, Benoit
2012-11-01 11:39 ` Pantelis Antoniou
2012-11-01 12:00 ` Koen Kooi
2012-11-01 13:06 ` Felipe Balbi
2012-11-01 13:33 ` Koen Kooi
2012-11-02 8:15 ` Cousson, Benoit
2012-11-02 8:43 ` Pantelis Antoniou
2012-11-03 8:23 ` Kevin Hilman
[not found] ` <40797D3D-D62C-4E15-B0DF-75636C1637EE-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2012-11-05 0:22 ` Grant Likely
2012-11-05 13:25 ` Pantelis Antoniou
2012-11-05 14:34 ` Grant Likely
[not found] ` <CACxGe6ubcRqDEGyRbNmwvAMGg5ujAKvPRWe9Vmd9tiHeB7=qNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-05 15:34 ` Tony Lindgren
2012-11-05 15:56 ` Rob Herring
2012-11-05 19:40 ` Grant Likely
2012-11-01 15:18 ` [PATCH 1/3] omap-device: Remove __init from omap_device_build family functions Pantelis Antoniou
2012-11-01 15:18 ` [PATCH 2/3] da8xx-dt: Create da8xx DT adapter device Pantelis Antoniou
2012-11-01 14:36 ` Tomi Valkeinen
2012-11-01 14:38 ` Pantelis Antoniou
2012-11-01 15:18 ` [PATCH 3/3] ti-tscadc-dt: Create ti-tscadc-dt " Pantelis Antoniou
-- strict thread matches above, loose matches on Subject: below --
2012-11-01 18:50 [PATCH 0/3] capebus moving omap_devices to mach-omap2 Jason Kridner
2012-11-01 19:07 ` Tony Lindgren
2012-11-02 9:26 ` Cousson, Benoit
2012-11-02 10:19 ` Koen Kooi
2012-11-05 0:32 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031175219.GH12739@atomide.com \
--to=tony@atomide.com \
--cc=Russ.Dill@ti.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=panto@antoniou-consulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).