From: Mike Turquette <mturquette@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: rnayak@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, patches@linaro.org
Subject: Re: [PATCH 14/26] ARM: OMAP3: clock: Add 3xxx data using common struct clk
Date: Thu, 8 Nov 2012 16:57:27 -0800 [thread overview]
Message-ID: <20121109005727.17381.5145@nucleus> (raw)
In-Reply-To: <alpine.DEB.2.00.1211090002380.20703@utopia.booyaka.com>
Quoting Paul Walmsley (2012-11-08 16:11:12)
> On Thu, 8 Nov 2012, Paul Walmsley wrote:
>
> > On Thu, 8 Nov 2012, Paul Walmsley wrote:
> >
> > > Am seeing warnings during the disable-unused-clocks phase of the boot on
> > > the OMAP3 test boards here.
> >
> > Similar problems during system suspend on 3530ES3 Beagle. Not sure
> > what's causing these yet. At this point the clockdomain usecounts
> > should be accurate.
>
> Here's a redacted debugging log for these cases. The suspend events start
> around the 30 second mark.
>
> One observation is that dpll4_m5x2_ck and dpll4_m6x2_ck are never enabled.
> The tracebacks occur when something in the suspend path tries to disable
> those clocks.
Hi Paul,
My instrumentation shows that dpll4_ck & dpll4_m2x2_ck are triggering
the WARNs:
[ 25.214599] _clkdm_clk_hwmod_disable: dpll4_m2x2_ck
[ 25.214599] ------------[ cut here ]------------
[ 25.214660] WARNING: at arch/arm/mach-omap2/clockdomain.c:967
_clkdm_clk_hwmod_disable+0xd0/0x118()
...
[ 25.215209] _clkdm_clk_hwmod_disable: dpll4_ck
[ 25.215209] ------------[ cut here ]------------
[ 25.215240] WARNING: at arch/arm/mach-omap2/clockdomain.c:967
_clkdm_clk_hwmod_disable+0xd0/0x118()
Patch that give that information:
diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-omap2/clockdomain.c
index 64e5046..a9d5965 100644
--- a/arch/arm/mach-omap2/clockdomain.c
+++ b/arch/arm/mach-omap2/clockdomain.c
@@ -947,7 +947,8 @@ static int _clkdm_clk_hwmod_enable(struct clockdomain *clkdm)
return 0;
}
-static int _clkdm_clk_hwmod_disable(struct clockdomain *clkdm)
+static int _clkdm_clk_hwmod_disable(struct clockdomain *clkdm,
+ struct clk *clk)
{
unsigned long flags;
@@ -957,6 +958,9 @@ static int _clkdm_clk_hwmod_disable(struct clockdomain *clkdm)
spin_lock_irqsave(&clkdm->lock, flags);
if (atomic_read(&clkdm->usecount) == 0) {
+ if (clk)
+ pr_err("%s: %s\n", __func__, __clk_get_name(clk));
+
spin_unlock_irqrestore(&clkdm->lock, flags);
WARN_ON(1); /* underflow */
return -ERANGE;
@@ -1026,7 +1030,7 @@ int clkdm_clk_disable(struct clockdomain *clkdm, struct clk *clk)
if (!clk)
return -EINVAL;
- return _clkdm_clk_hwmod_disable(clkdm);
+ return _clkdm_clk_hwmod_disable(clkdm, clk);
}
/**
@@ -1089,6 +1093,6 @@ int clkdm_hwmod_disable(struct clockdomain *clkdm, struct omap_hwmod *oh)
if (!oh)
return -EINVAL;
- return _clkdm_clk_hwmod_disable(clkdm);
+ return _clkdm_clk_hwmod_disable(clkdm, NULL);
}
Regards,
Mike
>
>
> - Paul
>
> [ 0.135528] enabling clkdm dpll4_clkdm during enable of clk dpll4_ck
> [ 0.135559] clockdomain: dpll4_clkdm: enabled
> [ 0.135589] enabling clkdm dpll4_clkdm during enable of clk dpll4_m2x2_ck
> [ 0.135681] disabling clkdm dpll4_clkdm during disable of clk dpll4_m2x2_ck
> [ 0.135681] disabling clkdm dpll4_clkdm during disable of clk dpll4_ck
> [ 0.135711] clockdomain: dpll4_clkdm: disabled
> [ 0.135772] enabling clkdm dpll4_clkdm during enable of clk dpll4_ck
> [ 0.135803] clockdomain: dpll4_clkdm: enabled
> [ 0.135833] enabling clkdm dpll4_clkdm during enable of clk dpll4_m2x2_ck
> [ 0.135894] disabling clkdm dpll4_clkdm during disable of clk dpll4_m2x2_ck
> [ 0.135925] disabling clkdm dpll4_clkdm during disable of clk dpll4_ck
> [ 0.135955] clockdomain: dpll4_clkdm: disabled
> [ 0.135986] enabling clkdm dpll4_clkdm during enable of clk dpll4_ck
> [ 0.136016] clockdomain: dpll4_clkdm: enabled
> [ 0.136047] enabling clkdm dpll4_clkdm during enable of clk dpll4_m2x2_ck
> [ 0.136138] disabling clkdm dpll4_clkdm during disable of clk dpll4_m2x2_ck
> [ 0.136169] disabling clkdm dpll4_clkdm during disable of clk dpll4_ck
> [ 0.136169] clockdomain: dpll4_clkdm: disabled
> [ 0.136260] enabling clkdm dpll4_clkdm during enable of clk dpll4_ck
> [ 0.136291] clockdomain: dpll4_clkdm: enabled
> [ 0.136322] enabling clkdm dpll4_clkdm during enable of clk dpll4_m2x2_ck
> [ 0.140594] enabling clkdm dpll4_clkdm during enable of clk dpll4_m4x2_ck
> [ 0.140686] enabling clkdm dpll4_clkdm during enable of clk dpll4_m3x2_ck
> [ 0.140838] disabling clkdm dpll4_clkdm during disable of clk dpll4_m3x2_ck
> [ 0.140930] disabling clkdm dpll4_clkdm during disable of clk dpll4_m4x2_ck
> [ 0.141479] enabling clkdm dpll4_clkdm during enable of clk dpll4_m4x2_ck
> [ 0.141571] disabling clkdm dpll4_clkdm during disable of clk dpll4_m4x2_ck
> [ 0.141601] enabling clkdm dpll4_clkdm during enable of clk dpll4_m4x2_ck
> [ 0.141662] disabling clkdm dpll4_clkdm during disable of clk dpll4_m4x2_ck
> [ 0.141693] enabling clkdm dpll4_clkdm during enable of clk dpll4_m4x2_ck
> [ 0.141784] disabling clkdm dpll4_clkdm during disable of clk dpll4_m4x2_ck
> [ 0.141815] enabling clkdm dpll4_clkdm during enable of clk dpll4_m3x2_ck
> [ 0.141876] disabling clkdm dpll4_clkdm during disable of clk dpll4_m3x2_ck
> [ 3.399200] disabling clkdm dpll4_clkdm during disable of clk dpll4_m6x2_ck
> [ 3.417694] [<c001c1cc>] (unwind_backtrace+0x0/0xf0) from [<c0043680>] (warn_slowpath_common+0x4c/0x64)
> [ 3.445251] ---[ end trace 72e2d7bdcf98ea8b ]---
> [ 3.450134] disabling clkdm dpll4_clkdm during disable of clk dpll4_m5x2_ck
> [ 3.453918] clockdomain: dpll4_clkdm: disabled
> [ 3.477569] [<c001c1cc>] (unwind_backtrace+0x0/0xf0) from [<c0043680>] (warn_slowpath_common+0x4c/0x64)
> [ 3.505096] ---[ end trace 72e2d7bdcf98ea8c ]---
> [ 3.531280] [<c001c1cc>] (unwind_backtrace+0x0/0xf0) from [<c0043680>] (warn_slowpath_common+0x4c/0x64)
> [ 3.558807] ---[ end trace 72e2d7bdcf98ea8d ]---
> [ 38.999145] disabling clkdm dpll4_clkdm during disable of clk dpll4_m2x2_ck
> [ 38.999267] [<c001c1cc>] (unwind_backtrace+0x0/0xf0) from [<c0043680>] (warn_slowpath_common+0x4c/0x64)
> [ 38.999816] ---[ end trace 72e2d7bdcf98ea8e ]---
> [ 38.999816] disabling clkdm dpll4_clkdm during disable of clk dpll4_ck
> [ 38.999908] [<c001c1cc>] (unwind_backtrace+0x0/0xf0) from [<c0043680>] (warn_slowpath_common+0x4c/0x64)
> [ 39.000366] ---[ end trace 72e2d7bdcf98ea8f ]---
> [ 42.169647] enabling clkdm dpll4_clkdm during enable of clk dpll4_ck
> [ 42.169647] clockdomain: dpll4_clkdm: enabled
> [ 42.169677] enabling clkdm dpll4_clkdm during enable of clk dpll4_m2x2_ck
> [ 45.730346] [<c001c1cc>] (unwind_backtrace+0x0/0xf0) from [<c0043680>] (warn_slowpath_common+0x4c/0x64)
> [ 45.795654] ---[ end trace 72e2d7bdcf98ea90 ]---
next prev parent reply other threads:[~2012-11-09 0:57 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 1:12 [PATCH v2 00/26] Move OMAP2+ over to common clk framework Mike Turquette
2012-11-08 1:12 ` [PATCH 01/26] ARM: OMAP: clock: Nuke plat/clock.c & reuse struct clk as clk_hw_omap Mike Turquette
2012-11-08 1:12 ` [PATCH 02/26] ARM: OMAP: hwmod: Fix up hwmod based clkdm accesses Mike Turquette
2012-11-12 22:15 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 03/26] ARM: OMAP4: clock: Convert to common clk Mike Turquette
2012-11-12 22:52 ` Paul Walmsley
2012-11-13 2:17 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 04/26] ARM: OMAP3: " Mike Turquette
2012-11-08 1:12 ` [PATCH 05/26] ARM: OMAP2: " Mike Turquette
2012-11-12 22:16 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 06/26] ARM: OMAP2xxx: clock: add APLL rate recalculation functions Mike Turquette
2012-11-08 1:12 ` [PATCH 07/26] ARM: OMAP: clock: list all clk_hw_omap clks to enable/disable autoidle Mike Turquette
2012-11-12 23:00 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 08/26] ARM: OMAP: clock: Define a function to enable clocks at init Mike Turquette
2012-11-12 23:01 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 09/26] ARM: OMAP2+: hwmod: Invoke init_clkdm before other init functions Mike Turquette
2012-11-08 1:12 ` [PATCH 10/26] ARM: OMAP: clock: Get rid of some clkdm assocations within clks Mike Turquette
2012-11-08 1:12 ` [PATCH 11/26] ARM: OMAP2+: clock: add OMAP CCF convenience macros to mach-omap2/clock.h Mike Turquette
2012-11-08 1:12 ` [PATCH 12/26] ARM: OMAP4: clock: Add 44xx data using common struct clk Mike Turquette
2012-11-13 1:37 ` Paul Walmsley
2012-11-13 2:16 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 13/26] ARM: AM33XX: clock: add clock data in common clock format Mike Turquette
2012-11-08 1:12 ` [PATCH 16/26] ARM: OMAP: clock: Switch to COMMON clk Mike Turquette
2012-11-08 1:12 ` [PATCH 17/26] ARM: OMAP: hwmod: Cleanup !CONFIG_COMMON_CLK parts Mike Turquette
2012-11-08 1:12 ` [PATCH 18/26] ARM: OMAP4: clock: " Mike Turquette
2012-11-08 1:12 ` [PATCH 20/26] ARM: omap3: " Mike Turquette
2012-11-08 1:12 ` [PATCH 22/26] ARM: AM33xx: clock: drop obsolete clock data Mike Turquette
2012-11-08 1:12 ` [PATCH 23/26] ARM: omap2: clock: Cleanup !CONFIG_COMMON_CLK parts Mike Turquette
2012-11-08 1:13 ` [PATCH 25/26] ARM: OMAP2+: clock: remove unnecessary declarations Mike Turquette
2012-11-08 1:13 ` [PATCH 26/26] ARM: OMAP2+: clock: Cleanup !CONFIG_COMMON_CLK parts Mike Turquette
2012-11-08 1:31 ` [PATCH v2 00/26] Move OMAP2+ over to common clk framework Mike Turquette
2012-11-08 1:42 ` Tony Lindgren
2012-11-08 1:54 ` Mike Turquette
2012-11-08 2:50 ` Paul Walmsley
2012-11-08 5:02 ` Rajendra Nayak
2012-11-08 5:19 ` Mike Turquette
2012-11-08 19:20 ` Kevin Hilman
[not found] ` <1352337181-29427-15-git-send-email-mturquette@ti.com>
2012-11-08 18:08 ` [PATCH 14/26] ARM: OMAP3: clock: Add 3xxx data using common struct clk Paul Walmsley
2012-11-08 21:52 ` Mike Turquette
2012-11-08 22:01 ` Paul Walmsley
2012-11-09 0:11 ` Paul Walmsley
2012-11-09 0:33 ` Paul Walmsley
2012-11-09 0:49 ` Paul Walmsley
2012-11-09 0:57 ` Mike Turquette [this message]
2012-11-08 23:31 ` [PATCH] ARM: OMAP2+: clockdomain: disabling unused clks Mike Turquette
2012-11-09 0:58 ` Paul Walmsley
2012-11-09 1:17 ` Mike Turquette
2012-11-09 19:06 ` Paul Walmsley
2012-11-09 19:08 ` Paul Walmsley
2012-11-09 19:40 ` Mike Turquette
2012-11-09 19:52 ` Paul Walmsley
2012-11-09 20:53 ` Paul Walmsley
2012-11-08 19:04 ` [PATCH v2 00/26] Move OMAP2+ over to common clk framework Vaibhav Hiremath
2012-11-09 21:12 ` Paul Walmsley
2012-11-09 22:09 ` Tony Lindgren
2012-11-09 22:18 ` Mike Turquette
2012-11-09 23:47 ` Paul Walmsley
2012-11-12 21:50 ` [PATCH] ARM: OMAP3+: DPLL: drop !CONFIG_COMMON_CLK sections Paul Walmsley
2012-11-12 22:30 ` Mike Turquette
[not found] ` <1352337181-29427-16-git-send-email-mturquette@ti.com>
[not found] ` <alpine.DEB.2.00.1211081532210.20703@utopia.booyaka.com>
2012-11-09 20:32 ` [PATCH 15/26] ARM: omap2: clock: Add 24xx data using common struct clk Paul Walmsley
2012-11-09 21:05 ` Mike Turquette
2012-11-09 21:22 ` Paul Walmsley
2012-11-09 22:21 ` Mike Turquette
2012-11-12 22:13 ` Paul Walmsley
2012-11-13 13:42 ` [PATCH v2 00/26] Move OMAP2+ over to common clk framework Laurent Pinchart
2012-11-13 16:43 ` Mike Turquette
2012-11-15 0:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109005727.17381.5145@nucleus \
--to=mturquette@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=patches@linaro.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).