From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] mmc: hsmmc: Fix NULL pointer dereference on unload when booted with device tree Date: Mon, 12 Nov 2012 14:16:09 -0800 Message-ID: <20121112221608.GS6801@atomide.com> References: <20121109182534.GR6801@atomide.com> <50A0F78C.6030600@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:44082 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752462Ab2KLWQL (ORCPT ); Mon, 12 Nov 2012 17:16:11 -0500 Content-Disposition: inline In-Reply-To: <50A0F78C.6030600@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Balaji T K Cc: Chris Ball , Venkatraman S , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org * Balaji T K [121112 05:22]: > On Friday 09 November 2012 11:55 PM, Tony Lindgren wrote: > >When booting with device tree, we don't have any pdata, and will > >get the following when trying to unload omap_hsmmc: > > > >Unable to handle kernel NULL pointer dereference at virtual address 00000044 > >pgd = edafc000 > >*pgd=adbbd831, *pte=00000000, *ppte=00000000 > >SMP ARM > >Modules linked in: omap_hsmmc(-) omap_serial pinctrl_single > >CPU: 1 Not tainted (3.7.0-rc4-00044-g8ca5f6a-dirty #245) > >PC is at omap_hsmmc_gpio_free+0x8/0x3c [omap_hsmmc] > >LR is at omap_hsmmc_remove+0xf0/0x174 [omap_hsmmc] > > > > >Signed-off-by: Tony Lindgren > > > >--- > > > >This is against v3.7-rc4, would be nice to get in during the -rc cycle. > > > Hi Tony, > > Got fixed by below commit, merged in rc5 > > http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commit;h=9ea28ecbeb090159a3383ff60b29dee00c489774 OK thanks! Tony