From: Felipe Balbi <balbi@ti.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: balbi@ti.com, Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH] ARM: OMAP2+: Fix compiler warning for 32k timer
Date: Fri, 16 Nov 2012 09:52:58 +0200 [thread overview]
Message-ID: <20121116075258.GC15669@arwen.pp.htv.fi> (raw)
In-Reply-To: <50A56033.6080908@ti.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Hi,
On Thu, Nov 15, 2012 at 03:35:47PM -0600, Jon Hunter wrote:
>
> On 11/15/2012 02:45 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Thu, Nov 15, 2012 at 01:44:04PM -0600, Jon Hunter wrote:
> >> +static struct of_device_id omap_counter_match[] __initdata = {
> >
> > not directly related to $SUBJECT, but shouldn't this be static const
> > __initconst ?
>
> Yes you are right. Looks like there are several other of_device_id
> structs in arch/arm/mach-omap2 that could be updated to const too.
here's a quick sed substitution for you:
$ sed -i 's/static \(struct of_device_id\)\s\(\w\+\[\]\)\s\(__initdata\|\)/static const \1 \2 __initconst/' arch/arm/*omap*/*.c
It worked fine here.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-16 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 19:44 [PATCH] ARM: OMAP2+: Fix compiler warning for 32k timer Jon Hunter
2012-11-15 20:45 ` Felipe Balbi
2012-11-15 21:35 ` Jon Hunter
2012-11-16 7:52 ` Felipe Balbi [this message]
2012-11-16 15:03 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116075258.GC15669@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=jon-hunter@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox