From: Felipe Balbi <balbi@ti.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers
Date: Fri, 16 Nov 2012 15:42:07 +0200 [thread overview]
Message-ID: <20121116134207.GB18527@arwen.pp.htv.fi> (raw)
In-Reply-To: <20121116124711.GA14886@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Fri, Nov 16, 2012 at 04:47:11AM -0800, Greg KH wrote:
> On Fri, Nov 16, 2012 at 10:17:19AM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Nov 16, 2012 at 12:07:54PM +0530, Kishon Vijay Abraham I wrote:
> > > commit 392142 moved event buffer allocation out of dwc3_core_init() but
> > > event buffer allocation uses the cached copy of hwparams to determine
> > > the number of event buffers and the caching is done in dwc3_core_init.
> > > So moved dwc3_cache_hwparams function before dwc3_alloc_event_buffers so
> > > that dwc3_alloc_event_buffers sees the correct number of event buffers.
> > >
> > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> >
> > My bad, what a regression I caused :-)
> >
> > Greg, can you take this one ?
>
> Yes, will do.
thanks a lot ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-16 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 6:37 [PATCH] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers Kishon Vijay Abraham I
2012-11-16 8:17 ` Felipe Balbi
[not found] ` <20121116081719.GA16568-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-16 12:47 ` Greg KH
2012-11-16 13:42 ` Felipe Balbi [this message]
2012-11-16 12:08 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116134207.GB18527@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox