From: Tony Lindgren <tony@atomide.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Felipe Balbi <balbi@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [RFC/RFT] OMAP: N770: remove custom implementation of ads7846_get_pendown_state
Date: Tue, 20 Nov 2012 10:27:06 -0800 [thread overview]
Message-ID: <20121120182704.GJ18567@atomide.com> (raw)
In-Reply-To: <20121120144333.GA20727@blackmetal.musicnaut.iki.fi>
* Aaro Koskinen <aaro.koskinen@iki.fi> [121120 06:45]:
> Hi,
>
> On Tue, Nov 20, 2012 at 12:30:53AM -0800, Dmitry Torokhov wrote:
> > The default implementation matches exactly our custom one so we can switch
> > to using the default one. As a bonus the driver will take care of setting
> > GPIO line for us.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >
> > No hardware so not tested...
>
> This seems to work.
>
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> A minor nitpick, the board is just 770 not N770. :-)
Nice. Looks safe to merge along with other input related
patches:
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2012-11-20 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 8:30 [RFC/RFT] OMAP: N770: remove custom implementation of ads7846_get_pendown_state Dmitry Torokhov
2012-11-20 14:43 ` Aaro Koskinen
2012-11-20 18:27 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120182704.GJ18567@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).