From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ricardo Neri <ricardo.neri@ti.com>
Cc: alsa-devel@alsa-project.org, tony@atomide.com,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
s-guiriec@ti.com, linux-omap@vger.kernel.org, lrg@ti.com
Subject: Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers
Date: Thu, 22 Nov 2012 10:03:59 +0900 [thread overview]
Message-ID: <20121122010358.GB4371@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50AD6FB0.3050808@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1169 bytes --]
On Wed, Nov 21, 2012 at 06:20:00PM -0600, Ricardo Neri wrote:
> On 11/19/2012 07:15 PM, Mark Brown wrote:
> >Yes, this would be more sensible if there's no board specifics involved.
> I think they are truly board-specific. For instance, there could be
> some board that does not have the OMAP HDMI IP wired to an external
> connector. We don't want the drivers to be probed in that case. If
> they are in common code, the devices will be created even if a board
> does not have HDMI output.
That's just a case of having a flag in the platform data for the device
saying "don't use this port" as opposed to having the entire ASoC device
instantiation infrastructure in there which is rather Linux specific.
> Something like this:
> sound_hdmi {
> compatible = "ti,omap-hdmi-card-audio";
> ti,model = "OMAP4HDMI";
> ti,hdmi_audio = <&hdmi>;
> ti,level_shifter = <&tpd12s015>;
> };
> The ASoC machine driver would create the platform device for the
> HDMI codec if the DT has the required nodes.
Why not just make this a property of the main HDMI controller - the
compatible property here looks like it's describing the Linux specifics
not the hardware?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-11-22 1:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 1:36 [PATCH v2 0/2] ARM: OMAP2+: HDMI: Update platform devices for audio Ricardo Neri
2012-11-16 1:36 ` [PATCH v2 1/2] ARM: OMAP2+: HDMI: Relocate audio platform device creation Ricardo Neri
2012-11-16 2:04 ` Mark Brown
2012-11-16 7:38 ` Tomi Valkeinen
2012-11-16 17:14 ` Ricardo Neri
2012-11-16 1:36 ` [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers Ricardo Neri
2012-11-16 2:05 ` Mark Brown
2012-11-16 7:52 ` Tomi Valkeinen
2012-11-16 18:05 ` Ricardo Neri
2012-11-19 12:58 ` Tomi Valkeinen
2012-11-20 1:15 ` Mark Brown
2012-11-22 0:20 ` Ricardo Neri
2012-11-22 1:03 ` Mark Brown [this message]
2012-11-23 2:03 ` Ricardo Neri
2012-11-23 2:12 ` Mark Brown
2012-11-23 20:14 ` Ricardo Neri
2012-11-22 12:52 ` Tomi Valkeinen
2012-11-23 2:03 ` Mark Brown
2012-11-23 2:12 ` Ricardo Neri
2012-11-22 0:19 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122010358.GB4371@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=ricardo.neri@ti.com \
--cc=s-guiriec@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).