From: "Mark A. Greer" <mgreer@animalcreek.com>
To: Mike Turquette <mturquette@ti.com>
Cc: Russ Dill <Russ.Dill@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't mark shared helper functions as inline
Date: Mon, 26 Nov 2012 14:00:38 -0700 [thread overview]
Message-ID: <20121126210038.GA3987@animalcreek.com> (raw)
In-Reply-To: <20121126195742.21126.16500@nucleus>
On Mon, Nov 26, 2012 at 11:57:42AM -0800, Mike Turquette wrote:
> Quoting Russ Dill (2012-11-26 11:20:09)
> > The helper functions that access the opaque struct clk should
> > not be marked inline since they are contained in clk.c, but expected
> > to be used by other compilation units. This causes compile errors
> > under gcc-4.7
> >
> > In file included from arch/arm/mach-omap2/clockdomain.c:25:0:
> > arch/arm/mach-omap2/clockdomain.c: In function ‘clkdm_clk_disable’:
> > include/linux/clk-provider.h:338:12: error: inlining failed in call to always_inline ‘__clk_get_enable_count’: function body not available
> > arch/arm/mach-omap2/clockdomain.c:1001:28: error: called from here
> > make[1]: *** [arch/arm/mach-omap2/clockdomain.o] Error 1
> > make: *** [arch/arm/mach-omap2] Error 2
> >
>
Hi Mike.
> Regardless, I'm still considering this patch. I've heard many times
> that we should trust the compiler to optimize for us and some folks look
> down on inlining in general. If anyone has an opinion on removing
> inlines from the common clk core then please do speak up.
You should take a look at "Chapter 15: The inline disease" in
Documentation/CodingStyle.
Mark
--
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-26 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 19:20 [PATCH] Don't mark shared helper functions as inline Russ Dill
2012-11-26 19:57 ` Mike Turquette
2012-11-26 21:00 ` Mark A. Greer [this message]
2012-11-27 17:52 ` Russ Dill
2013-01-12 0:37 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126210038.GA3987@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=Russ.Dill@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).