OMAP build now completely broken in latest arm-soc

OMAP build now completely broken in latest arm-soc

[Russell King - ARM Linux]

Not much more to say...

arch/arm/plat-omap/i2c.c:35:1: error: expected identifier or '(' before '<<' token

But also, the:

arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used

warning is still there.

Re: OMAP build now completely broken in latest arm-soc

[Olof Johansson]

Hi,

On Sun, Nov 25, 2012 at 1:37 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> Not much more to say...
>
> arch/arm/plat-omap/i2c.c:35:1: error: expected identifier or '(' before '<<' token

Hmm. In for-next, line 35 is a blank line.

Could this be because of a merge conflict in your local version? This
is one of the files that has conflicts with mainline right now; I'll
look to see if we can resolve those in our tree later today.


> But also, the:
>
> arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used
>
> warning is still there.

There's a fix for this in Tony's tree, but he hasn't sent up the pull
request for it yet.


-Olof

Re: OMAP build now completely broken in latest arm-soc

[Russell King - ARM Linux]

On Sun, Nov 25, 2012 at 05:56:58AM -0800, Olof Johansson wrote:
> Hi,
> 
> On Sun, Nov 25, 2012 at 1:37 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > Not much more to say...
> >
> > arch/arm/plat-omap/i2c.c:35:1: error: expected identifier or '(' before '<<' token
> 
> Hmm. In for-next, line 35 is a blank line.
> 
> Could this be because of a merge conflict in your local version? This
> is one of the files that has conflicts with mainline right now; I'll
> look to see if we can resolve those in our tree later today.

Hmm, it looks like a merge conflict which didn't get fixed up... and
looking at it, it's beyond what I'd call trivial to fix.

So I'll shut down the build system until that can be resolved properly;
as OMAP is effectively unbuildable there's not much point it running the
builds.

Re: OMAP build now completely broken in latest arm-soc

[Olof Johansson]

Hi,

On Sun, Nov 25, 2012 at 6:07 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Sun, Nov 25, 2012 at 05:56:58AM -0800, Olof Johansson wrote:
>> Hi,
>>
>> On Sun, Nov 25, 2012 at 1:37 AM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>> > Not much more to say...
>> >
>> > arch/arm/plat-omap/i2c.c:35:1: error: expected identifier or '(' before '<<' token
>>
>> Hmm. In for-next, line 35 is a blank line.
>>
>> Could this be because of a merge conflict in your local version? This
>> is one of the files that has conflicts with mainline right now; I'll
>> look to see if we can resolve those in our tree later today.
>
> Hmm, it looks like a merge conflict which didn't get fixed up... and
> looking at it, it's beyond what I'd call trivial to fix.
>
> So I'll shut down the build system until that can be resolved properly;
> as OMAP is effectively unbuildable there's not much point it running the
> builds.

Tony, Tomi,

I've taken a stab at resolving these conflicts. They seem to come from
the cleanups combined with fixes that went upstream, and it seems like
we want to stick to the arm-soc versions for most of the conflicts.

I've pushed a merge of 3.7-rc7 into next/cleanup (and for-next) of
arm-soc, can you please check and see if this is the correct
resolution? As far as I can tell it is, but a double-check would be
appreciated.

Conflicts were in:

        arch/arm/mach-omap2/omap_hwmod_44xx_data.c
        arch/arm/plat-omap/i2c.c
        drivers/video/omap2/dss/dss.c

The hwmod data was trivial (include files). i2c was a little hairier,
a revert in mainline -- I presumed we're still good with our arm-soc
contents so I stuck close to what we had there. The DSS change seems
to be done completely differently in mainline, i.e. the surrounding
code is different to what we have in arm-soc today, and it looks like
the bugfix (3630-specific stuff) is taken care of in the version we
had. So I stuck to that.

But, please speak up ASAP if the above doesn't look correct, since we
want to fix it up before we merge much on top.


Thanks!


-Olof

Re: OMAP build now completely broken in latest arm-soc

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

On 2012-11-26 08:00, Olof Johansson wrote:

> Tony, Tomi,
> 
> I've taken a stab at resolving these conflicts. They seem to come from
> the cleanups combined with fixes that went upstream, and it seems like
> we want to stick to the arm-soc versions for most of the conflicts.
> 
> I've pushed a merge of 3.7-rc7 into next/cleanup (and for-next) of
> arm-soc, can you please check and see if this is the correct
> resolution? As far as I can tell it is, but a double-check would be
> appreciated.
> 
> Conflicts were in:
> 
>         arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>         arch/arm/plat-omap/i2c.c
>         drivers/video/omap2/dss/dss.c
> 
> The hwmod data was trivial (include files). i2c was a little hairier,
> a revert in mainline -- I presumed we're still good with our arm-soc
> contents so I stuck close to what we had there. The DSS change seems
> to be done completely differently in mainline, i.e. the surrounding
> code is different to what we have in arm-soc today, and it looks like
> the bugfix (3630-specific stuff) is taken care of in the version we
> had. So I stuck to that.
> 
> But, please speak up ASAP if the above doesn't look correct, since we
> want to fix it up before we merge much on top.

The dss.c is resolved correctly.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]

Re: OMAP build now completely broken in latest arm-soc

[Tony Lindgren]

* Olof Johansson <olof@lixom.net> [121125 22:02]:
> Hi,
> 
> On Sun, Nov 25, 2012 at 6:07 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Sun, Nov 25, 2012 at 05:56:58AM -0800, Olof Johansson wrote:
> >> Hi,
> >>
> >> On Sun, Nov 25, 2012 at 1:37 AM, Russell King - ARM Linux
> >> <linux@arm.linux.org.uk> wrote:
> >> > Not much more to say...
> >> >
> >> > arch/arm/plat-omap/i2c.c:35:1: error: expected identifier or '(' before '<<' token
> >>
> >> Hmm. In for-next, line 35 is a blank line.
> >>
> >> Could this be because of a merge conflict in your local version? This
> >> is one of the files that has conflicts with mainline right now; I'll
> >> look to see if we can resolve those in our tree later today.
> >
> > Hmm, it looks like a merge conflict which didn't get fixed up... and
> > looking at it, it's beyond what I'd call trivial to fix.
> >
> > So I'll shut down the build system until that can be resolved properly;
> > as OMAP is effectively unbuildable there's not much point it running the
> > builds.
> 
> Tony, Tomi,
> 
> I've taken a stab at resolving these conflicts. They seem to come from
> the cleanups combined with fixes that went upstream, and it seems like
> we want to stick to the arm-soc versions for most of the conflicts.
> 
> I've pushed a merge of 3.7-rc7 into next/cleanup (and for-next) of
> arm-soc, can you please check and see if this is the correct
> resolution? As far as I can tell it is, but a double-check would be
> appreciated.
> 
> Conflicts were in:
> 
>         arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>         arch/arm/plat-omap/i2c.c
>         drivers/video/omap2/dss/dss.c
> 
> The hwmod data was trivial (include files). i2c was a little hairier,
> a revert in mainline -- I presumed we're still good with our arm-soc
> contents so I stuck close to what we had there. The DSS change seems
> to be done completely differently in mainline, i.e. the surrounding
> code is different to what we have in arm-soc today, and it looks like
> the bugfix (3630-specific stuff) is taken care of in the version we
> had. So I stuck to that.

Looks like that i2c revert probably needs a fixup patch as we still
don't have the prerequisites merged. Anyways, the fixup should be done
in mach-omap2/i2c.c instead of plat-omap/i2c.c, so your merge fix
is OK.
 
> But, please speak up ASAP if the above doesn't look correct, since we
> want to fix it up before we merge much on top.

That's good, thanks.

Regards,

Tony

Re: OMAP build now completely broken in latest arm-soc

[Tony Lindgren]

* Olof Johansson <olof@lixom.net> [121125 05:59]:
> On Sun, Nov 25, 2012 at 1:37 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > But also, the:
> >
> > arch/arm/mach-omap2/timer.c:163:28: warning: 'omap_counter_match' defined but not used
> >
> > warning is still there.
> 
> There's a fix for this in Tony's tree, but he hasn't sent up the pull
> request for it yet.

Sent a pull request for that as "omap late timer clean-up
(and a warning fix) for v3.8 merge window". The fix is there
there as the topmost third patch, but that probably does not
matter in this case as the regression was introduced in the
patches queued.

Let me know if you want it separately though.

Regards,

Tony