From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Radhesh Fadnis <radhesh.fadnis@ti.com>,
Jon Hunter <jon-hunter@ti.com>
Subject: Re: OMAP* Latest build failures
Date: Wed, 28 Nov 2012 15:16:08 +0000 [thread overview]
Message-ID: <20121128151608.GY3332@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <50B619F1.3000207@ti.com>
On Wed, Nov 28, 2012 at 10:04:33AM -0400, Eduardo Valentin wrote:
> Tony, Russell,
>
> On 20-11-2012 13:57, Tony Lindgren wrote:
>> * Russell King - ARM Linux <linux@arm.linux.org.uk> [121117 01:35]:
>>> On Wed, Nov 14, 2012 at 09:26:43AM +0000, Russell King - ARM Linux wrote:
>>> And the randconfig found:
>>>
>>> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_readl':
>>> drivers/staging/omap-thermal/omap-bandgap.c:46:2: error: implicit declaration of function 'readl'
>>> drivers/staging/omap-thermal/omap-bandgap.c: In function 'omap_bandgap_writel':
>>> drivers/staging/omap-thermal/omap-bandgap.c:51:2: error: implicit declaration of function 'writel'
>>>
>>> Which, as its in staging, maybe its not important but it's another source
>>> of unnecessary failure.
>
> Well, it is important, thanks for checking this code. I appreciate if
> you keep your report.
>
>>
>> Radhesh & Eduardo, can you fix this?
>>
>
> This has been already fixed:
> https://patchwork.kernel.org/patch/1734621/
>
> And is already queued by Greg (staging-next):
> http://git.kernel.org/?p=linux/kernel/git/gregkh/staging.git;a=commit;h=2aeeb8acfc19f8a9f283081bbf77919b61b92042
Good. Now, there's also this too:
drivers/staging/omap-thermal/omap-thermal-common.c: In function 'omap_thermal_expose_sensor':
drivers/staging/omap-thermal/omap-thermal-common.c:259:28: error: storage size of 'pdata' isn't known
drivers/staging/omap-thermal/omap-thermal-common.c:261:2: error: 'data' undeclared (first use in this function)
drivers/staging/omap-thermal/omap-thermal-common.c:264:3: error: implicit declaration of function 'omap_thermal_build_pdata'
drivers/staging/omap-thermal/omap-thermal-common.c: In function 'omap_thermal_build_cpufreq_clip':
drivers/staging/omap-thermal/omap-thermal-common.c:330:41: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:343:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:343:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:343:6: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:344:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:344:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:344:6: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:345:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:345:3: error: invalid use of undefined type 'struct freq_clip_table'
drivers/staging/omap-thermal/omap-thermal-common.c:345:6: error: dereferencing pointer to incomplete type
drivers/staging/omap-thermal/omap-thermal-common.c:375:2: error: too many arguments to function 'cpufreq_cooling_register'
Is it also fixed in Gregkh's staging-next branch?
prev parent reply other threads:[~2012-11-28 15:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 9:26 OMAP* Latest build failures Russell King - ARM Linux
2012-11-14 10:08 ` Peter Ujfalusi
2012-11-14 10:35 ` Russell King - ARM Linux
2012-11-14 11:45 ` Tomi Valkeinen
2012-11-14 16:48 ` Tony Lindgren
2012-11-14 16:59 ` Tony Lindgren
2012-11-14 17:17 ` Tony Lindgren
2012-11-14 17:44 ` Russell King - ARM Linux
2012-11-14 17:42 ` Russell King - ARM Linux
2012-11-17 9:33 ` Russell King - ARM Linux
2012-11-20 17:57 ` Tony Lindgren
2012-11-20 23:00 ` Jon Hunter
2012-11-28 15:18 ` Russell King - ARM Linux
2012-11-28 21:43 ` Jon Hunter
2012-11-28 14:04 ` Eduardo Valentin
2012-11-28 15:16 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128151608.GY3332@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=eduardo.valentin@ti.com \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=radhesh.fadnis@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).