From: Tony Lindgren <tony@atomide.com>
To: Daniel Mack <zonque@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
jon-hunter@ti.com, avinashphilip@ti.com, x0148406@ti.com,
paul@pwsan.com, nsekhar@ti.com, jacmet@sunsite.dk
Subject: Re: [PATCH v5 3/4] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs
Date: Wed, 28 Nov 2012 08:42:01 -0800 [thread overview]
Message-ID: <20121128164200.GC5312@atomide.com> (raw)
In-Reply-To: <1354113509-7972-4-git-send-email-zonque@gmail.com>
* Daniel Mack <zonque@gmail.com> [121128 06:40]:
Please add a patch description here.
Regards,
Tony
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> ---
> arch/arm/mach-omap2/gpmc-nand.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch/arm/mach-omap2/gpmc-nand.c
> index f9f23a2..c8a72ba 100644
> --- a/arch/arm/mach-omap2/gpmc-nand.c
> +++ b/arch/arm/mach-omap2/gpmc-nand.c
> @@ -92,17 +92,18 @@ static int omap2_nand_gpmc_retime(
> static bool gpmc_hwecc_bch_capable(enum omap_ecc ecc_opt)
> {
> /* support only OMAP3 class */
> - if (!cpu_is_omap34xx()) {
> + if (!cpu_is_omap34xx() && !soc_is_am33xx()) {
> pr_err("BCH ecc is not supported on this CPU\n");
> return 0;
> }
>
> /*
> - * For now, assume 4-bit mode is only supported on OMAP3630 ES1.x, x>=1.
> - * Other chips may be added if confirmed to work.
> + * For now, assume 4-bit mode is only supported on OMAP3630 ES1.x, x>=1
> + * and AM33xx derivates. Other chips may be added if confirmed to work.
> */
> if ((ecc_opt == OMAP_ECC_BCH4_CODE_HW) &&
> - (!cpu_is_omap3630() || (GET_OMAP_REVISION() == 0))) {
> + (!cpu_is_omap3630() || (GET_OMAP_REVISION() == 0)) &&
> + (!soc_is_am33xx())) {
> pr_err("BCH 4-bit mode is not supported on this CPU\n");
> return 0;
> }
> --
> 1.7.11.7
>
next prev parent reply other threads:[~2012-11-28 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 14:38 [PATCH v5 0/4] OMAP GPMC DT bindings Daniel Mack
2012-11-28 14:38 ` [PATCH v5 1/4] mtd: omap-nand: pass device_node in platform data Daniel Mack
2012-11-28 14:38 ` [PATCH v5 2/4] ARM: OMAP: gpmc-nand: drop __init annotation Daniel Mack
2012-11-28 14:38 ` [PATCH v5 3/4] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs Daniel Mack
2012-11-28 16:42 ` Tony Lindgren [this message]
2012-11-28 14:38 ` [PATCH v5 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND Daniel Mack
2012-11-28 16:46 ` Tony Lindgren
2012-11-28 16:59 ` Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2012-11-28 16:58 [PATCH RESEND v5 0/4] OMAP GPMC DT bindings Daniel Mack
2012-11-28 16:58 ` [PATCH v5 3/4] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128164200.GC5312@atomide.com \
--to=tony@atomide.com \
--cc=avinashphilip@ti.com \
--cc=jacmet@sunsite.dk \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=x0148406@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).