From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] mach-omap2/board-igep0020.c: Fix reboot problem Date: Fri, 14 Dec 2012 09:19:50 -0800 Message-ID: <20121214171950.GP4989@atomide.com> References: <1352995613-17994-1-git-send-email-matthias.bgg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:63877 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756538Ab2LNRTz (ORCPT ); Fri, 14 Dec 2012 12:19:55 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Robert Nelson Cc: Matthias Brugger , Russell King , linux-omap@vger.kernel.org, martinez.javier@gmail.com, eballetbo@iseebcn.com, Matthias Brugger * Robert Nelson [121115 08:44]: > On Thu, Nov 15, 2012 at 10:06 AM, Matthias Brugger > wrote: > > When rebooting an OMAP3530 at 125 MHz, the reboot hangs. > > This patch adds a generic power save script, which resets the TWL4030 when a > > warm reset occures. This way the OMAP3530 does not hang on reboot. > > > > Signed-off-by: Matthias Brugger > > --- > > arch/arm/mach-omap2/board-igep0020.c | 36 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > > > diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c > > index 48d5e41..9ba1c4b 100644 > > --- a/arch/arm/mach-omap2/board-igep0020.c > > +++ b/arch/arm/mach-omap2/board-igep0020.c > > @@ -487,11 +487,47 @@ static struct twl4030_keypad_data igep2_keypad_pdata = { > > .rep = 1, > > }; > > > > +static struct twl4030_ins wrst_seq[] __initdata = { > > + {MSG_SINGULAR(DEV_GRP_NULL, 0x1b, RES_STATE_OFF), 2}, > > + {MSG_SINGULAR(DEV_GRP_P1, 0xf, RES_STATE_WRST), 15}, > > + {MSG_SINGULAR(DEV_GRP_P1, 0x10, RES_STATE_WRST), 15}, > > + {MSG_SINGULAR(DEV_GRP_P1, 0x7, RES_STATE_WRST), 0x60}, > > + {MSG_SINGULAR(DEV_GRP_P1, 0x19, RES_STATE_ACTIVE), 2}, > > + {MSG_SINGULAR(DEV_GRP_NULL, 0x1b, RES_STATE_ACTIVE), 2}, > > +}; > > + > > +static struct twl4030_script wrst_script __initdata = { > > + .script = wrst_seq, > > + .size = ARRAY_SIZE(wrst_seq), > > + .flags = TWL4030_WRST_SCRIPT, > > +}; > > + > > +static struct twl4030_script *twl4030_scripts[] __initdata = { > > + &wrst_script, > > +}; > > + > > +static struct twl4030_resconfig twl4030_rconfig[] = { > > + { .resource = RES_HFCLKOUT, .devgroup = DEV_GRP_P3, .type = -1, > > + .type2 = -1 }, > > + { .resource = RES_VDD1, .devgroup = DEV_GRP_P1, .type = -1, > > + .type2 = -1 }, > > + { .resource = RES_VDD2, .devgroup = DEV_GRP_P1, .type = -1, > > + .type2 = -1 }, > > + { 0, 0}, > > +}; > > + > > +static struct twl4030_power_data igep_twl4030_power_data = { > > + .scripts = twl4030_scripts, > > + .num = ARRAY_SIZE(twl4030_scripts), > > + .resource_config = twl4030_rconfig, > > +}; > > + > > static struct twl4030_platform_data igep_twldata = { > > /* platform_data for children goes here */ > > .gpio = &igep_twl4030_gpio_pdata, > > .vmmc1 = &igep_vmmc1, > > .vio = &igep_vio, > > + .power = &igep_twl4030_power_data, > > }; > > > > static struct i2c_board_info __initdata igep2_i2c3_boardinfo[] = { > > -- > > 1.7.9.5 > > > > -- > > Sweet, this also fixes the software reboot lockup I've been bisecting > on the Beagle C4 (omap3530), when the ONDEMAND governor is enabled.. > (applied the same changes to the beagle's board file: > board-omap3beagle.c) > > Can we make this script generic for all omap35xx/twl4030 boards that need it? > > So far, no regressions in a quick boot/reboot test of DM3730 Beagle xM > C that shares the board file... Any news on making this fix generic? Regards, Tony