twl4030_charger seems to be broken by switch from 'notifier' to 'mailbox'.

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]


Hi,

 this commit:

commit c9721438c009adf8e81d376839ed037c53b9b8d9
Author: Kishon Vijay Abraham I <kishon@ti.com>
Date:   Fri Jun 22 17:40:52 2012 +0530

    usb: musb: twl: use mailbox API to send VBUS or ID events
    
    The atomic notifier from twl4030/twl6030 to notifiy VBUS and ID events,
    is replaced by a direct call to omap musb blue.
    
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>


Seems to have broken twl4030_charger.c.
This code relies on the notifier to know when the USB has been plugged in and
so it should consider enabling the charger.

now that the notification has gone, the charger never turns on.

If I put the atomic_notifier_call_chain() calls back in, then the charger is
activated as appropriate.

What is the plan here?  Should the calls go back, or is there some way for
twl4030_charger to hook into the "mailbox"?  Or is there some other way it
should work?

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]