* [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-12 11:45 [PATCH] regulator: core: if voltage scaling fails, restore original Paolo Pisati
@ 2012-12-12 11:45 ` Paolo Pisati
2012-12-12 18:13 ` Robert Nelson
0 siblings, 1 reply; 14+ messages in thread
From: Paolo Pisati @ 2012-12-12 11:45 UTC (permalink / raw)
To: linux-omap
Cc: Paul Walmsley, Liam Girdwood, Mark Brown, linux-kernel,
Paolo Pisati
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
drivers/regulator/core.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index e872c8b..c347fd0 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2250,6 +2250,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
{
struct regulator_dev *rdev = regulator->rdev;
int ret = 0;
+ int old_min_uV, old_max_uV;
mutex_lock(&rdev->mutex);
@@ -2271,18 +2272,29 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
if (ret < 0)
goto out;
+
+ /* restore original values in case of error */
+ old_min_uV = regulator->min_uV;
+ old_max_uV = regulator->max_uV;
regulator->min_uV = min_uV;
regulator->max_uV = max_uV;
ret = regulator_check_consumers(rdev, &min_uV, &max_uV);
if (ret < 0)
- goto out;
+ goto out2;
ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
-
+ if (ret < 0)
+ goto out2;
+
out:
mutex_unlock(&rdev->mutex);
return ret;
+out2:
+ regulator->min_uV = old_min_uV;
+ regulator->max_uV = old_max_uV;
+ mutex_unlock(&rdev->mutex);
+ return ret;
}
EXPORT_SYMBOL_GPL(regulator_set_voltage);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-12 11:45 ` [PATCH] regulator: core: if voltage scaling fails, restore original voltage values Paolo Pisati
@ 2012-12-12 18:13 ` Robert Nelson
2012-12-12 19:00 ` Felipe Balbi
0 siblings, 1 reply; 14+ messages in thread
From: Robert Nelson @ 2012-12-12 18:13 UTC (permalink / raw)
To: Paolo Pisati; +Cc: linux-omap, linux-kernel
On Wed, Dec 12, 2012 at 5:45 AM, Paolo Pisati
<paolo.pisati@canonical.com> wrote:
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
> drivers/regulator/core.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index e872c8b..c347fd0 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2250,6 +2250,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
> {
> struct regulator_dev *rdev = regulator->rdev;
> int ret = 0;
> + int old_min_uV, old_max_uV;
>
> mutex_lock(&rdev->mutex);
>
> @@ -2271,18 +2272,29 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
> ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
> if (ret < 0)
> goto out;
> +
> + /* restore original values in case of error */
> + old_min_uV = regulator->min_uV;
> + old_max_uV = regulator->max_uV;
> regulator->min_uV = min_uV;
> regulator->max_uV = max_uV;
>
> ret = regulator_check_consumers(rdev, &min_uV, &max_uV);
> if (ret < 0)
> - goto out;
> + goto out2;
>
> ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
> -
> + if (ret < 0)
> + goto out2;
> +
> out:
> mutex_unlock(&rdev->mutex);
> return ret;
> +out2:
> + regulator->min_uV = old_min_uV;
> + regulator->max_uV = old_max_uV;
> + mutex_unlock(&rdev->mutex);
> + return ret;
> }
> EXPORT_SYMBOL_GPL(regulator_set_voltage);
>
> --
> 1.7.10.4
Nice! This fixes the 800Mhz lockup on bootup after a software reset we
were seeing on the Beagle xM's with v3.7.x/v3.6.x...
Tested-by: Robert Nelson <robertcnelson@gmail.com>
Regards,
--
Robert Nelson
http://www.rcn-ee.com/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-12 18:13 ` Robert Nelson
@ 2012-12-12 19:00 ` Felipe Balbi
0 siblings, 0 replies; 14+ messages in thread
From: Felipe Balbi @ 2012-12-12 19:00 UTC (permalink / raw)
To: Robert Nelson; +Cc: Paolo Pisati, linux-omap, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2231 bytes --]
Hi,
On Wed, Dec 12, 2012 at 12:13:35PM -0600, Robert Nelson wrote:
> On Wed, Dec 12, 2012 at 5:45 AM, Paolo Pisati
> <paolo.pisati@canonical.com> wrote:
> > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> > ---
> > drivers/regulator/core.c | 16 ++++++++++++++--
> > 1 file changed, 14 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> > index e872c8b..c347fd0 100644
> > --- a/drivers/regulator/core.c
> > +++ b/drivers/regulator/core.c
> > @@ -2250,6 +2250,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
> > {
> > struct regulator_dev *rdev = regulator->rdev;
> > int ret = 0;
> > + int old_min_uV, old_max_uV;
> >
> > mutex_lock(&rdev->mutex);
> >
> > @@ -2271,18 +2272,29 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
> > ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
> > if (ret < 0)
> > goto out;
> > +
> > + /* restore original values in case of error */
> > + old_min_uV = regulator->min_uV;
> > + old_max_uV = regulator->max_uV;
> > regulator->min_uV = min_uV;
> > regulator->max_uV = max_uV;
> >
> > ret = regulator_check_consumers(rdev, &min_uV, &max_uV);
> > if (ret < 0)
> > - goto out;
> > + goto out2;
> >
> > ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
> > -
> > + if (ret < 0)
> > + goto out2;
> > +
> > out:
> > mutex_unlock(&rdev->mutex);
> > return ret;
> > +out2:
> > + regulator->min_uV = old_min_uV;
> > + regulator->max_uV = old_max_uV;
> > + mutex_unlock(&rdev->mutex);
> > + return ret;
> > }
> > EXPORT_SYMBOL_GPL(regulator_set_voltage);
> >
> > --
> > 1.7.10.4
>
> Nice! This fixes the 800Mhz lockup on bootup after a software reset we
> were seeing on the Beagle xM's with v3.7.x/v3.6.x...
>
> Tested-by: Robert Nelson <robertcnelson@gmail.com>
if this fixes a boot lockup with older kernel, I believe this deserves a
Cc: stable@vger.kernel.org.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] [resend] regulator: core: if voltage scaling fails, restore original values
@ 2012-12-13 9:12 Paolo Pisati
2012-12-13 9:13 ` [PATCH] regulator: core: if voltage scaling fails, restore original voltage values Paolo Pisati
0 siblings, 1 reply; 14+ messages in thread
From: Paolo Pisati @ 2012-12-13 9:12 UTC (permalink / raw)
To: linux-omap
Cc: Paul Walmsley, Liam Girdwood, Mark Brown, linux-kernel,
Robert Nelson, Felipe Balbi, stable, Paolo Pisati
[resent with cc: stable and a bit more context]
I've been experiencing solid hangs on my beaglexm with v3.7 after
kexec:
here is my .config (omap2plus + EHCI/OHCI + CPUFREQ + DEVTMP):
http://people.canonical.com/~ppisati/omap3_cpufreq_kexec/config
here is the diff i added to get some debugging:
http://people.canonical.com/~ppisati/omap3_cpufreq_kexec/dpll-debug.diff
here is a trace of the kexeced kernel:
http://people.canonical.com/~ppisati/omap3_cpufreq_kexec/kexec-boot.txt
And after a second look it's clear what's going on:
[...]
[ 5.575744] cpu cpu0: cpufreq-omap: 300 MHz, -1 mV --> 800 MHz, 1325 mV
[ 5.582946] voltdm_scale: No voltage scale API registered for vdd_mpu_iva
[ 5.590332] cpu cpu0: omap_target: unable to scale voltage up.
[1]
[ 5.596649] notification 1 of frequency transition to 300000 kHz
[ 5.603179] FREQ: 300000 - CPU: 0
[ 5.606597] governor: change or update limits
[ 5.611572] __cpufreq_governor for CPU 0, event 3
[ 5.616699] setting to 800000 kHz because of event 3
[ 5.622039] target for CPU 0: 800000 kHz, relation 1
[ 5.627441] request for target 800000 kHz (relation: 1) for cpu 0
[ 5.634063] target is 2 (800000 kHz, 2)
[ 5.638183] notification 0 of frequency transition to 800000 kHz
[ 5.644775] cpu cpu0: cpufreq-omap: 300 MHz, -1 mV --> 800 MHz, 1325 mV
[2]
[hangs here]
first time[1] it tries to ramp up frequency (and thus voltage),
regulator_set_voltage() returns an error and we exit:
omap-cpufreq.c::omap_target():
...
dev_dbg(mpu_dev, "cpufreq-omap: %u MHz, %ld mV --> %u MHz, %ld mV\n",
freqs.old / 1000, volt_old ? volt_old / 1000 : -1,
freqs.new / 1000, volt ? volt / 1000 : -1);
/* scaling up? scale voltage before frequency */
if (mpu_reg && (freqs.new > freqs.old)) {
r = regulator_set_voltage(mpu_reg, volt - tol, volt + tol);
if (r < 0) {
dev_warn(mpu_dev, "%s: unable to scale voltage up.\n",
__func__);
freqs.new = freqs.old;
goto done;
}
}
ret = clk_set_rate(mpu_clk, freqs.new * 1000);
...
but inside regulator_set_voltage(), we save the new regulator voltage before
actually ramping up:
core.c::regulator_set_voltage():
...
regulator->min_uV = min_uV;
regulator->max_uV = max_uV;
ret = regulator_check_consumers(rdev, &min_uV, &max_uV);
if (ret < 0)
goto out2;
ret = _regulator_do_set_voltage(rdev, min_uV, max_uV); <-- ERROR!!!
if (ret < 0)
goto out2;
...
and by the time we try to change frequency again[2], regulator_set_voltage()
is a noop because it thinks we are already at the desired voltage:
core.c::regulator_set_voltage():
...
/* If we're setting the same range as last time the change
* should be a noop (some cpufreq implementations use the same
* voltage for multiple frequencies, for example).
*/
if (regulator->min_uV == min_uV && regulator->max_uV == max_uV)
goto out;
...
and as a consequence, in omap_target(), we call clk_set_rate() with
the wrong voltage.
The attached patch restore the original regulator voltage values in case
of an error.
CCing stable@ since it predates 2.6.38rc1 when the noop optimization was
introduced:
commit 95a3c23ae620c1b4c499746e70f4034bdc067737
Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Thu Dec 16 15:49:37 2010 +0000
regulator: Optimise out noop voltage changes
Paolo Pisati (1):
regulator: core: if voltage scaling fails, restore original voltage
values
drivers/regulator/core.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-13 9:12 [PATCH] [resend] regulator: core: if voltage scaling fails, restore original values Paolo Pisati
@ 2012-12-13 9:13 ` Paolo Pisati
2012-12-13 9:47 ` Felipe Balbi
2012-12-15 14:53 ` Mark Brown
0 siblings, 2 replies; 14+ messages in thread
From: Paolo Pisati @ 2012-12-13 9:13 UTC (permalink / raw)
To: linux-omap
Cc: Paul Walmsley, Liam Girdwood, Mark Brown, linux-kernel,
Robert Nelson, Felipe Balbi, stable, Paolo Pisati
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Tested-by: Robert Nelson <robertcnelson@gmail.com>
---
drivers/regulator/core.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index e872c8b..c347fd0 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2250,6 +2250,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
{
struct regulator_dev *rdev = regulator->rdev;
int ret = 0;
+ int old_min_uV, old_max_uV;
mutex_lock(&rdev->mutex);
@@ -2271,18 +2272,29 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
if (ret < 0)
goto out;
+
+ /* restore original values in case of error */
+ old_min_uV = regulator->min_uV;
+ old_max_uV = regulator->max_uV;
regulator->min_uV = min_uV;
regulator->max_uV = max_uV;
ret = regulator_check_consumers(rdev, &min_uV, &max_uV);
if (ret < 0)
- goto out;
+ goto out2;
ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
-
+ if (ret < 0)
+ goto out2;
+
out:
mutex_unlock(&rdev->mutex);
return ret;
+out2:
+ regulator->min_uV = old_min_uV;
+ regulator->max_uV = old_max_uV;
+ mutex_unlock(&rdev->mutex);
+ return ret;
}
EXPORT_SYMBOL_GPL(regulator_set_voltage);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-13 9:13 ` [PATCH] regulator: core: if voltage scaling fails, restore original voltage values Paolo Pisati
@ 2012-12-13 9:47 ` Felipe Balbi
2012-12-14 15:39 ` Paolo Pisati
2012-12-15 14:53 ` Mark Brown
1 sibling, 1 reply; 14+ messages in thread
From: Felipe Balbi @ 2012-12-13 9:47 UTC (permalink / raw)
To: Paolo Pisati
Cc: linux-omap, Paul Walmsley, Liam Girdwood, Mark Brown,
linux-kernel, Robert Nelson, Felipe Balbi, stable
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
On Thu, Dec 13, 2012 at 10:13:00AM +0100, Paolo Pisati wrote:
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> Tested-by: Robert Nelson <robertcnelson@gmail.com>
please read Documentation/stable_kernel_rules.txt, you'll see this is
wrong.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-13 9:47 ` Felipe Balbi
@ 2012-12-14 15:39 ` Paolo Pisati
2012-12-14 15:40 ` Felipe Balbi
0 siblings, 1 reply; 14+ messages in thread
From: Paolo Pisati @ 2012-12-14 15:39 UTC (permalink / raw)
To: Felipe Balbi
Cc: Paolo Pisati, linux-omap, Paul Walmsley, Liam Girdwood,
Mark Brown, linux-kernel, Robert Nelson, stable
On Thu, Dec 13, 2012 at 11:47:15AM +0200, Felipe Balbi wrote:
> On Thu, Dec 13, 2012 at 10:13:00AM +0100, Paolo Pisati wrote:
> > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> > Tested-by: Robert Nelson <robertcnelson@gmail.com>
>
> please read Documentation/stable_kernel_rules.txt, you'll see this is
> wrong.
you mean that i should have waited for the commit to hit Linus's tree before
cc-ing stable?
--
bye,
p.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-14 15:39 ` Paolo Pisati
@ 2012-12-14 15:40 ` Felipe Balbi
2012-12-15 14:15 ` Mark Brown
0 siblings, 1 reply; 14+ messages in thread
From: Felipe Balbi @ 2012-12-14 15:40 UTC (permalink / raw)
To: Paolo Pisati
Cc: Felipe Balbi, linux-omap, Paul Walmsley, Liam Girdwood,
Mark Brown, linux-kernel, Robert Nelson, stable
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
Hi,
On Fri, Dec 14, 2012 at 04:39:43PM +0100, Paolo Pisati wrote:
> On Thu, Dec 13, 2012 at 11:47:15AM +0200, Felipe Balbi wrote:
> > On Thu, Dec 13, 2012 at 10:13:00AM +0100, Paolo Pisati wrote:
> > > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> > > Tested-by: Robert Nelson <robertcnelson@gmail.com>
> >
> > please read Documentation/stable_kernel_rules.txt, you'll see this is
> > wrong.
>
> you mean that i should have waited for the commit to hit Linus's tree before
> cc-ing stable?
No no, I mean that before you SoB you should have a:
Cc: <stable@vger.kernel.org> # v3.x v3.y ...
Something like the commit below:
commit 041d81f493d90c940ec41f0ec98bc7c4f2fba431
Author: Felipe Balbi <balbi@ti.com>
Date: Thu Oct 4 11:58:00 2012 +0300
usb: dwc3: gadget: fix 'endpoint always busy' bug
If a USB transfer has already been started, meaning
we have already issued StartTransfer command to that
particular endpoint, DWC3_EP_BUSY flag has also
already been set.
When we try to cancel this transfer which is already
in controller's cache, we will not receive XferComplete
event and we must clear DWC3_EP_BUSY in order to allow
subsequent requests to be properly started.
The best place to clear that flag is right after issuing
DWC3_DEPCMD_ENDTRANSFER.
Cc: stable@vger.kernel.org # v3.4 v3.5 v3.6
Reported-by: Moiz Sonasath <m-sonasath@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-14 15:40 ` Felipe Balbi
@ 2012-12-15 14:15 ` Mark Brown
2012-12-15 14:57 ` Felipe Balbi
0 siblings, 1 reply; 14+ messages in thread
From: Mark Brown @ 2012-12-15 14:15 UTC (permalink / raw)
To: Felipe Balbi
Cc: Paolo Pisati, linux-omap, Paul Walmsley, Liam Girdwood,
linux-kernel, Robert Nelson, stable
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
On Fri, Dec 14, 2012 at 05:40:30PM +0200, Felipe Balbi wrote:
> No no, I mean that before you SoB you should have a:
> Cc: <stable@vger.kernel.org> # v3.x v3.y ...
It's perfectly OK to omit this unless there's an awareness that the
backport won't work on some kernels.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-13 9:13 ` [PATCH] regulator: core: if voltage scaling fails, restore original voltage values Paolo Pisati
2012-12-13 9:47 ` Felipe Balbi
@ 2012-12-15 14:53 ` Mark Brown
1 sibling, 0 replies; 14+ messages in thread
From: Mark Brown @ 2012-12-15 14:53 UTC (permalink / raw)
To: Paolo Pisati
Cc: linux-omap, Paul Walmsley, Liam Girdwood, linux-kernel,
Robert Nelson, Felipe Balbi, stable
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
On Thu, Dec 13, 2012 at 10:13:00AM +0100, Paolo Pisati wrote:
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> Tested-by: Robert Nelson <robertcnelson@gmail.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-15 14:15 ` Mark Brown
@ 2012-12-15 14:57 ` Felipe Balbi
2012-12-17 14:15 ` Mark Brown
0 siblings, 1 reply; 14+ messages in thread
From: Felipe Balbi @ 2012-12-15 14:57 UTC (permalink / raw)
To: Mark Brown
Cc: Felipe Balbi, Paolo Pisati, linux-omap, Paul Walmsley,
Liam Girdwood, linux-kernel, Robert Nelson, stable
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
Hi,
On Sat, Dec 15, 2012 at 11:15:20PM +0900, Mark Brown wrote:
> On Fri, Dec 14, 2012 at 05:40:30PM +0200, Felipe Balbi wrote:
>
> > No no, I mean that before you SoB you should have a:
>
> > Cc: <stable@vger.kernel.org> # v3.x v3.y ...
>
> It's perfectly OK to omit this unless there's an awareness that the
> backport won't work on some kernels.
that's not what Greg says, but fair enough. Won't discuss it...
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-15 14:57 ` Felipe Balbi
@ 2012-12-17 14:15 ` Mark Brown
2012-12-17 15:18 ` Felipe Balbi
0 siblings, 1 reply; 14+ messages in thread
From: Mark Brown @ 2012-12-17 14:15 UTC (permalink / raw)
To: Felipe Balbi
Cc: Paolo Pisati, linux-omap, Paul Walmsley, Liam Girdwood,
linux-kernel, Robert Nelson, stable
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On Sat, Dec 15, 2012 at 04:57:38PM +0200, Felipe Balbi wrote:
> On Sat, Dec 15, 2012 at 11:15:20PM +0900, Mark Brown wrote:
> > It's perfectly OK to omit this unless there's an awareness that the
> > backport won't work on some kernels.
> that's not what Greg says, but fair enough. Won't discuss it...
Uh, no. Think about this for a minute - we want bug fixes backporting,
we don't want to be putting process blockers in the way of that
especially not in the cases where fixes apply to all the stable kernels
that are currently active.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-17 14:15 ` Mark Brown
@ 2012-12-17 15:18 ` Felipe Balbi
2012-12-17 15:45 ` Mark Brown
0 siblings, 1 reply; 14+ messages in thread
From: Felipe Balbi @ 2012-12-17 15:18 UTC (permalink / raw)
To: Mark Brown
Cc: Felipe Balbi, Paolo Pisati, linux-omap, Paul Walmsley,
Liam Girdwood, linux-kernel, Robert Nelson, stable
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
Hi,
On Mon, Dec 17, 2012 at 02:15:36PM +0000, Mark Brown wrote:
> On Sat, Dec 15, 2012 at 04:57:38PM +0200, Felipe Balbi wrote:
> > On Sat, Dec 15, 2012 at 11:15:20PM +0900, Mark Brown wrote:
>
> > > It's perfectly OK to omit this unless there's an awareness that the
> > > backport won't work on some kernels.
>
> > that's not what Greg says, but fair enough. Won't discuss it...
>
> Uh, no. Think about this for a minute - we want bug fixes backporting,
> we don't want to be putting process blockers in the way of that
> especially not in the cases where fixes apply to all the stable kernels
> that are currently active.
then omit the # v3.x, v3.y part, but Cc: stable@vger.kernel.org should
still be there
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values
2012-12-17 15:18 ` Felipe Balbi
@ 2012-12-17 15:45 ` Mark Brown
0 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2012-12-17 15:45 UTC (permalink / raw)
To: Felipe Balbi
Cc: Paolo Pisati, linux-omap, Paul Walmsley, Liam Girdwood,
linux-kernel, Robert Nelson, stable
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Mon, Dec 17, 2012 at 05:18:48PM +0200, Felipe Balbi wrote:
> On Mon, Dec 17, 2012 at 02:15:36PM +0000, Mark Brown wrote:
> > Uh, no. Think about this for a minute - we want bug fixes backporting,
> > we don't want to be putting process blockers in the way of that
> > especially not in the cases where fixes apply to all the stable kernels
> > that are currently active.
> then omit the # v3.x, v3.y part, but Cc: stable@vger.kernel.org should
> still be there
Oh, yes - that's needed. Sorry, I thought it was the v3.x bit you were
complaining was missing.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-12-17 15:45 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-13 9:12 [PATCH] [resend] regulator: core: if voltage scaling fails, restore original values Paolo Pisati
2012-12-13 9:13 ` [PATCH] regulator: core: if voltage scaling fails, restore original voltage values Paolo Pisati
2012-12-13 9:47 ` Felipe Balbi
2012-12-14 15:39 ` Paolo Pisati
2012-12-14 15:40 ` Felipe Balbi
2012-12-15 14:15 ` Mark Brown
2012-12-15 14:57 ` Felipe Balbi
2012-12-17 14:15 ` Mark Brown
2012-12-17 15:18 ` Felipe Balbi
2012-12-17 15:45 ` Mark Brown
2012-12-15 14:53 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-12-12 11:45 [PATCH] regulator: core: if voltage scaling fails, restore original Paolo Pisati
2012-12-12 11:45 ` [PATCH] regulator: core: if voltage scaling fails, restore original voltage values Paolo Pisati
2012-12-12 18:13 ` Robert Nelson
2012-12-12 19:00 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).