* Re: [PATCH v2] New Nokia RX-51 power supply battery driver
[not found] ` <5320319.2WmO5VDT8j@pali>
@ 2012-11-19 18:20 ` Anton Vorontsov
2012-11-21 19:20 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Anton Vorontsov @ 2012-11-19 18:20 UTC (permalink / raw)
To: Pali Rohár
Cc: David Woodhouse, linux-kernel, Joerg Reisenweber, Ivaylo Dimitrov,
Tony Lindgren, linux-omap
On Mon, Nov 19, 2012 at 01:18:29PM +0100, Pali Rohár wrote:
[...]
> Ok. Here is missing patch which register this driver in Nokia N900 board code. Without it driver is not loaded.
Cc'ing OMAP folks.
> From 0b60efd06a71668439bcb761c6572dd7df91dc17 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com>
> Date: Mon, 19 Nov 2012 09:05:24 +0100
> Subject: [PATCH 1/3] ARM: OMAP: rx51: Register platform device for
> rx51_battery driver
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 020e03c..fe1ac7e 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -271,11 +271,17 @@ static struct platform_device rx51_charger_device = {
> },
> };
>
> +static struct platform_device rx51_battery_device = {
> + .name = "rx51-battery",
> + .id = -1,
> +};
> +
> static void __init rx51_charger_init(void)
> {
> WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> GPIOF_OUT_INIT_HIGH, "isp1704_reset"));
>
> + platform_device_register(&rx51_battery_device);
> platform_device_register(&rx51_charger_device);
> }
>
> --
> 1.7.10.4
>
> --
> Pali Rohár
> pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] New Nokia RX-51 power supply battery driver
2012-11-19 18:20 ` [PATCH v2] New Nokia RX-51 power supply battery driver Anton Vorontsov
@ 2012-11-21 19:20 ` Tony Lindgren
2012-12-17 6:55 ` Anton Vorontsov
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2012-11-21 19:20 UTC (permalink / raw)
To: Anton Vorontsov
Cc: Pali Rohár, David Woodhouse, linux-kernel, Joerg Reisenweber,
Ivaylo Dimitrov, linux-omap
* Anton Vorontsov <cbouatmailru@gmail.com> [121119 10:25]:
> On Mon, Nov 19, 2012 at 01:18:29PM +0100, Pali Rohár wrote:
> [...]
> > Ok. Here is missing patch which register this driver in Nokia N900 board code. Without it driver is not loaded.
>
> Cc'ing OMAP folks.
Looks OK to me queue with the other patches in the series:
Acked-by: Tony Lindgren <tony@atomide.com>
> From 0b60efd06a71668439bcb761c6572dd7df91dc17 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com>
> > Date: Mon, 19 Nov 2012 09:05:24 +0100
> > Subject: [PATCH 1/3] ARM: OMAP: rx51: Register platform device for
> > rx51_battery driver
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
> > arch/arm/mach-omap2/board-rx51-peripherals.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> > index 020e03c..fe1ac7e 100644
> > --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> > +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> > @@ -271,11 +271,17 @@ static struct platform_device rx51_charger_device = {
> > },
> > };
> >
> > +static struct platform_device rx51_battery_device = {
> > + .name = "rx51-battery",
> > + .id = -1,
> > +};
> > +
> > static void __init rx51_charger_init(void)
> > {
> > WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> > GPIOF_OUT_INIT_HIGH, "isp1704_reset"));
> >
> > + platform_device_register(&rx51_battery_device);
> > platform_device_register(&rx51_charger_device);
> > }
> >
> > --
> > 1.7.10.4
> >
> > --
> > Pali Rohár
> > pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] New Nokia RX-51 power supply battery driver
2012-11-21 19:20 ` Tony Lindgren
@ 2012-12-17 6:55 ` Anton Vorontsov
0 siblings, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2012-12-17 6:55 UTC (permalink / raw)
To: Tony Lindgren
Cc: Pali Rohár, David Woodhouse, linux-kernel, Joerg Reisenweber,
Ivaylo Dimitrov, linux-omap
On Wed, Nov 21, 2012 at 11:20:43AM -0800, Tony Lindgren wrote:
> * Anton Vorontsov <cbouatmailru@gmail.com> [121119 10:25]:
> > On Mon, Nov 19, 2012 at 01:18:29PM +0100, Pali Rohár wrote:
> > [...]
> > > Ok. Here is missing patch which register this driver in Nokia N900 board code. Without it driver is not loaded.
> >
> > Cc'ing OMAP folks.
>
> Looks OK to me queue with the other patches in the series:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Applied, thanks!
(I'll make a second pull request for this window, but no sure if it will
make it. We will see.)
Thanks,
Anton
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-17 6:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <19040462.WFXWijAIDd@pali>
[not found] ` <2562836.SjVVyiPAk1@pali>
[not found] ` <20121118231239.GC29066@lizard.sbx05977.paloaca.wayport.net>
[not found] ` <5320319.2WmO5VDT8j@pali>
2012-11-19 18:20 ` [PATCH v2] New Nokia RX-51 power supply battery driver Anton Vorontsov
2012-11-21 19:20 ` Tony Lindgren
2012-12-17 6:55 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).