From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: OMAP: Split vrfb.c to remove last remaining cpu_is_omap usage
Date: Mon, 17 Dec 2012 09:19:38 -0800 [thread overview]
Message-ID: <20121217171938.GS4989@atomide.com> (raw)
In-Reply-To: <50CEE65C.20009@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [121217 01:33]:
> On 2012-12-16 22:03, Tony Lindgren wrote:
> > Looks like we missed plat-omap/fb.c for cpu_is_omap usage
> > mach-omap2. This is the last user of cpu_is_omap, so let's
> > quickly fix it up so we can finally remove plat/cpu.h for
> > omap2lus.
> >
> > We want to limit cpu_is_omap macro usage to mach-omap2 only so
> > we can make plat/cpu.h private. After this we can finally drop
> > plat/cpu.h for omap2+.
> >
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> > arch/arm/mach-omap1/Makefile | 2 +
> > arch/arm/mach-omap1/fb.c | 80 ++++++++++++++++++++++++++++++++++++++++++
> > arch/arm/mach-omap2/Makefile | 2 +
> > arch/arm/mach-omap2/fb.c | 50 +-------------------------
> > arch/arm/plat-omap/Makefile | 2 +
> > 5 files changed, 85 insertions(+), 51 deletions(-)
> > create mode 100644 arch/arm/mach-omap1/fb.c
> > rename arch/arm/{plat-omap/fb.c => mach-omap2/fb.c} (76%)
>
> Ok, I didn't realize that plat-omap cannot refer to cpu_is_omap either.
We could, but I'd rather not as what we have left in plat-omap should
all be just drivers eventually. And in this case the fb code is already
completely separate for omap1 and omap2+, so it's better just to split
it up. It makes fixing up the initcalls for omap2+ multiplatform easier
when booting on other SoCs than omap.
> The patch looks fine, except the subject should say "split fb.c", not
> "split vrfb.c".
Thanks I'll update the subject.
Regards,
Tony
next prev parent reply other threads:[~2012-12-17 17:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 20:03 [PATCH 0/2] drop plat/cpu.h for omap2plus Tony Lindgren
2012-12-16 20:03 ` [PATCH 1/2] ARM: OMAP: Split vrfb.c to remove last remaining cpu_is_omap usage Tony Lindgren
2012-12-17 9:31 ` Tomi Valkeinen
2012-12-17 17:19 ` Tony Lindgren [this message]
2012-12-16 20:03 ` [PATCH 2/2] ARM: OMAP2+: Drop plat/cpu.h for omap2plus Tony Lindgren
2012-12-17 9:04 ` Laurent Pinchart
2012-12-17 10:48 ` Jean Pihet
2012-12-17 14:59 ` Mauro Carvalho Chehab
2012-12-20 6:42 ` [PATCH 0/2] drop " Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217171938.GS4989@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).