From: Paul Walmsley <paul@pwsan.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Felipe Balbi <balbi@ti.com>, Vaibhav Hiremath <hvaibhav@ti.com>
Subject: [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings
Date: Sun, 23 Dec 2012 18:24:58 -0700 [thread overview]
Message-ID: <20121224012456.13698.41839.stgit@dusk.lan> (raw)
In-Reply-To: <20121224012304.13698.43551.stgit@dusk.lan>
Commit 1fe97c8f6a1de67a5f56e029a818903d5bed8017 ("ARM: OMAP: Make OMAP
clocksource source selection using kernel param") results in a new warning
from sparse:
arch/arm/plat-omap/counter_32k.c:86:12: warning: symbol 'omap_init_clocksource_32k' was not declared. Should it be static?
Fix by adding a temporary header file, needed until the 32k counter
code is moved to drivers/.
arch/arm/plat-omap/include/plat/counter-32k.h can't be added due to
ARM CONFIG_ARCH_MULTIPLATFORM restrictions on the use of the "plat/"
include path shortcut.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/counter_32k.c | 2 ++
arch/arm/plat-omap/counter_32k.h | 20 ++++++++++++++++++++
2 files changed, 22 insertions(+)
create mode 100644 arch/arm/plat-omap/counter_32k.h
diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
index f3771cd..1d129d3 100644
--- a/arch/arm/plat-omap/counter_32k.c
+++ b/arch/arm/plat-omap/counter_32k.c
@@ -22,6 +22,8 @@
#include <asm/mach/time.h>
#include <asm/sched_clock.h>
+#include "counter_32k.h"
+
/* OMAP2_32KSYNCNT_CR_OFF: offset of 32ksync counter register */
#define OMAP2_32KSYNCNT_REV_OFF 0x0
#define OMAP2_32KSYNCNT_REV_SCHEME (0x3 << 30)
diff --git a/arch/arm/plat-omap/counter_32k.h b/arch/arm/plat-omap/counter_32k.h
new file mode 100644
index 0000000..4366ce5
--- /dev/null
+++ b/arch/arm/plat-omap/counter_32k.h
@@ -0,0 +1,20 @@
+/*
+ * OMAP 32k counter function prototypes
+ *
+ * Copyright (C) 2012 Texas Instruments, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * XXX Needed until the OMAP 32k counter code is moved to somewhere under
+ * drivers/.
+ */
+#ifndef __ARCH_ARM_PLAT_OMAP_COUNTER_32K_H
+#define __ARCH_ARM_PLAT_OMAP_COUNTER_32K_H
+
+#include <linux/kernel.h>
+
+extern int omap_init_clocksource_32k(void __iomem *vbase);
+
+#endif
next prev parent reply other threads:[~2012-12-24 1:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 1:24 [PATCH 0/3] ARM: OMAP: resolve sparse warnings with v3.8-rc1 Paul Walmsley
2012-12-24 1:24 ` Paul Walmsley [this message]
2012-12-25 16:22 ` [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings Santosh Shilimkar
2013-01-01 18:13 ` Tony Lindgren
2013-01-02 19:36 ` Paul Walmsley
2012-12-24 1:25 ` [PATCH 2/3] ARM: OMAP AM33xx: hwmod data: " Paul Walmsley
2012-12-26 4:10 ` Mugunthan V N
2012-12-24 1:25 ` [PATCH 3/3] ARM: OMAP: SRAM: " Paul Walmsley
2013-01-01 18:15 ` Tony Lindgren
2013-01-02 19:37 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224012456.13698.41839.stgit@dusk.lan \
--to=paul@pwsan.com \
--cc=balbi@ti.com \
--cc=hvaibhav@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).