From: "Mark A. Greer" <mgreer@animalcreek.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jon Hunter <jon-hunter@ti.com>
Subject: Re: [PATCH 00/15] OMAP SHAM & AES Crypto Updates
Date: Tue, 25 Dec 2012 12:29:37 -0700 [thread overview]
Message-ID: <20121225192937.GD4846@animalcreek.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1212230836160.16045@utopia.booyaka.com>
On Sun, Dec 23, 2012 at 08:40:43AM +0000, Paul Walmsley wrote:
> Hi Mark,
>
> On Fri, 21 Dec 2012, Mark A. Greer wrote:
>
> > From: "Mark A. Greer" <mgreer@animalcreek.com>
> >
> > [This series supersedes the hwmod related patches sent in the
> > "crypto: omap-sham updates" and "crypto: omap-aes updates"
> > series a few weeks ago.]
> >
> > This series adds hwmod support for the OMAP SHAM and AES
> > modules on OMAP2, OMAP3, and OMAP4/AM33XX SoCs. It also
> > adds device tree info for those modules.
>
> Thanks for working on this, this will get us much closer to being able to
> convert the hwmod code into an OMAP bus. I haven't looked closely at
> these patches yet, but a few comments/questions:
>
> - Looks like the two DTS patches are the ones with direct dependencies on
> the DMA Engine support patches that you mentioned.
The patch(es) that convert the drivers to use
dma_request_slave_channel_compat() will cause problems too if the
patch that adds that call isn't in your branch. AFAIK, this is the
latest version, https://patchwork.kernel.org/patch/1459231/ from
Jon Hunter.
> Any objection to me
> taking the series without those two patches? Then once the DMA Engine
> series goes in, maybe those AM33xx DTS patches can go up?
No, no objections at all. I will track/resubmit/whatever the ones that
need to go in later.
> - The patch series causes AM3517/3505 to crash. I'd guess this is due to
> the SHAM/AES modules being initialized on those chips, but they probably
> don't exist there. Can you change the initialization for those on OMAP3
> to only take place on OMAP34xx/36xx GP? I guess you'd need to create new
> lists for those in the hwmod init.
Oh. :(
Sure, I'll do what you suggest when I'm back to work in the new year.
Thanks Paul.
Mark
--
next prev parent reply other threads:[~2012-12-25 19:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 16:28 [PATCH 00/15] OMAP SHAM & AES Crypto Updates Mark A. Greer
2012-12-21 16:28 ` [PATCH 01/15] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-12-21 16:28 ` [PATCH 02/15] ARM: OMAP2xxx: hwmod: Add DMA support for SHAM module Mark A. Greer
2012-12-21 16:28 ` [PATCH 03/15] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2013-02-08 17:42 ` Paul Walmsley
2013-02-11 18:07 ` Mark A. Greer
2012-12-21 16:28 ` [PATCH 04/15] ARM: OMAP2+: Remove unnecessary message when no SHA IP is present Mark A. Greer
2012-12-21 16:28 ` [PATCH 05/15] ARM: OMAP2+: Only manually add hwmod data when DT not used Mark A. Greer
2012-12-21 16:28 ` [PATCH 06/15] ARM: AM33XX: Add sha0 crypto clock data Mark A. Greer
2012-12-21 16:28 ` [PATCH 07/15] ARM: AM33XX: hwmod: Update and uncomment SHA0 module data Mark A. Greer
2012-12-21 16:28 ` [PATCH 08/15] ARM: dts: Add SHAM data and documentation for AM33XX Mark A. Greer
2012-12-21 16:28 ` [PATCH 09/15] ARM: OMAP2xxx: hwmod: Convert AES crypto devcie data to hwmod Mark A. Greer
2012-12-21 16:28 ` [PATCH 10/15] ARM: OMAP3xxx: hwmod: Convert AES crypto device " Mark A. Greer
2012-12-21 16:28 ` [PATCH 11/15] ARM: OMAP2+: Remove unnecessary message when no AES IP is present Mark A. Greer
2012-12-21 16:28 ` [PATCH 12/15] ARM: OMAP2+: Only manually add hwmod data when DT not used Mark A. Greer
2012-12-21 16:28 ` [PATCH 13/15] ARM: AM33XX: Add aes0 crypto clock data Mark A. Greer
2012-12-23 15:47 ` Peter Korsgaard
2012-12-21 16:28 ` [PATCH 14/15] ARM: AM33XX: hwmod: Update and uncomment AES0 module data Mark A. Greer
2012-12-21 16:28 ` [PATCH 15/15] ARM: dts: Add AES data and documentation for AM33XX Mark A. Greer
2012-12-21 19:09 ` [PATCH 00/15] OMAP SHAM & AES Crypto Updates Peter Korsgaard
2012-12-21 19:22 ` Mark A. Greer
2012-12-23 16:03 ` Peter Korsgaard
2012-12-25 19:17 ` Mark A. Greer
2012-12-23 8:40 ` Paul Walmsley
2012-12-25 19:29 ` Mark A. Greer [this message]
2012-12-25 19:34 ` Mark A. Greer
2013-01-08 20:38 ` Mark A. Greer
2013-01-17 19:13 ` Paul Walmsley
2013-01-17 22:27 ` Mark A. Greer
2013-01-28 19:16 ` Mark A. Greer
2013-02-01 17:35 ` Paul Walmsley
2013-02-01 20:18 ` Mark A. Greer
2013-02-08 17:45 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121225192937.GD4846@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).