From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Yariv Subject: Re: [PATCH] hwspinlock/core: Add testing capabilities Date: Sun, 30 Dec 2012 16:27:10 +0200 Message-ID: <20121230142710.GA16250@WorkStation.localnet> References: <20121230112018.GA14042@WorkStation.localnet> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "steve.zhan" Cc: Ohad Ben-Cohen , linux-kernel@vger.kernel.org, linux-arm , linux-omap List-Id: linux-omap@vger.kernel.org Hi Steve, On Sun, Dec 30, 2012 at 10:13:08PM +0800, steve.zhan wrote: > Hi, > =A0=A0 Acked-by: Steve zhan zhanzhenbo@gmail.com > =A0 > =A0=A0 "I'd rather not test the spinlocks after they are registering = as they > might already be in use by then." >=20 > =A0=A0=A0 Why? I think user must use it after hwspin_lock_register ha= ve retured > sucess. Once the spinlocks are registered anyone can request and acquire these. The tests could then interfere with any users of the hwspinlock layer, or simply fail (because the spinlocks might already be acquired). Thanks, Ido.