From: Tony Lindgren <tony@atomide.com>
To: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Cc: cjb@laptop.org, devicetree-discuss@lists.ozlabs.org,
linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
santosh.shilimkar@ti.com, zonque@gmail.com
Subject: Re: [PATCH] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.
Date: Thu, 10 Jan 2013 12:22:04 -0800 [thread overview]
Message-ID: <20130110202203.GD14149@atomide.com> (raw)
In-Reply-To: <1356041532-919-1-git-send-email-andreas.fenkart@streamunlimited.com>
* Andreas Fenkart <andreas.fenkart@streamunlimited.com> [121220 14:15]:
> Without functional clock the omap_hsmmc module can't forward
> SDIO IRQs to the system. This patch reconfigures dat1 line
> as a gpio while the fclk is off. And uses SDIO IRQ detection of
> the module, while fclk is present.
Looks pretty good to me, however I could not figure out what
to apply this on for testing. It fails to apply at least against
current linux next, can you please update against that?
> +static void omap_hsmmc_enable_sdio_irq(struct mmc_host *mmc, int enable)
> +{
> + struct omap_hsmmc_host *host = mmc_priv(mmc);
> + u32 irq_mask;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&host->irq_lock, flags);
> +
> + host->sdio_irq_en = (enable != 0) ? true : false;
> +
> + if (host->active_pinmux) {
> + irq_mask = OMAP_HSMMC_READ(host->base, ISE);
> + if (enable)
> + irq_mask |= CIRQ_ENABLE;
> + else
> + irq_mask &= ~CIRQ_ENABLE;
> + OMAP_HSMMC_WRITE(host->base, IE, irq_mask);
> +
> + if (!host->req_in_progress)
> + OMAP_HSMMC_WRITE(host->base, ISE, irq_mask);
> +
> +#if 0
> + OMAP_HSMMC_READ(host->base, IE); /* flush posted write */
> +#endif
Maybe just replace #if 0 with just a comment in case it turns out to be
needed for some cases?
Regards,
Tony
next prev parent reply other threads:[~2013-01-10 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 11:18 omap_hsmmc: SDIO IRQ on AM335x family Andreas Fenkart
2012-11-30 17:40 ` Tony Lindgren
2012-11-30 18:57 ` Daniel Mack
2012-12-20 22:04 ` Andreas Fenkart
2012-12-20 22:12 ` [PATCH] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode Andreas Fenkart
2013-01-10 20:22 ` Tony Lindgren [this message]
2013-02-18 10:26 ` Daniel Mack
2013-02-18 12:42 ` Andreas Fenkart
2013-02-08 13:05 ` Grant Likely
2013-01-03 19:48 ` omap_hsmmc: SDIO IRQ on AM335x family Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110202203.GD14149@atomide.com \
--to=tony@atomide.com \
--cc=andreas.fenkart@streamunlimited.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).