From: Thierry Reding <thierry.reding@avionic-design.de>
To: Philip Avinash <avinashphilip@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
nsekhar@ti.com, gururaja.hebbar@ti.com
Subject: Re: [PATCH 1/2] pwm: pwm-tiehrpwm: Low power sleep support
Date: Mon, 14 Jan 2013 08:08:56 +0100 [thread overview]
Message-ID: <20130114070855.GA21994@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1357823024-17585-2-git-send-email-avinashphilip@ti.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Thu, Jan 10, 2013 at 06:33:43PM +0530, Philip Avinash wrote:
[...]
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
[...]
> +static int ehrpwm_pwm_suspend(struct device *dev)
> +{
> + struct ehrpwm_pwm_chip *pc = dev_get_drvdata(dev);
> +
> + ehrpwm_pwm_context_save(pc);
> + pm_runtime_put_sync(dev);
> + return 0;
> +}
> +
> +static int ehrpwm_pwm_resume(struct device *dev)
> +{
> + struct ehrpwm_pwm_chip *pc = dev_get_drvdata(dev);
> +
> + pm_runtime_get_sync(dev);
> + ehrpwm_pwm_context_restore(pc);
> + return 0;
> +}
According to Documentation/power/runtime_pm.txt, the PM core runs the
pm_runtime_get_noresume() and pm_runtime_put_sync() before executing the
.suspend() and .resume() callbacks. Are you sure you need to call them
here explicitly?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-14 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 13:03 [PATCH 0/2] LOW power sleep support for TI PWM submodules Philip Avinash
2013-01-10 13:03 ` [PATCH 1/2] pwm: pwm-tiehrpwm: Low power sleep support Philip Avinash
2013-01-14 7:08 ` Thierry Reding [this message]
2013-01-16 12:14 ` Philip, Avinash
2013-01-16 12:30 ` Thierry Reding
2013-01-10 13:03 ` [PATCH 2/2] pwm: pwm-tiecap: " Philip Avinash
2013-01-14 7:10 ` Thierry Reding
2013-01-16 12:13 ` Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114070855.GA21994@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=avinashphilip@ti.com \
--cc=gururaja.hebbar@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).