linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-omap@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH 0/2] OMAP3 ISP: Simplify clock usage
Date: Mon, 14 Jan 2013 17:10:15 -0800	[thread overview]
Message-ID: <20130115011015.23734.75232@quantum> (raw)
In-Reply-To: <1357652634-17668-1-git-send-email-laurent.pinchart@ideasonboard.com>

Quoting Laurent Pinchart (2013-01-08 05:43:52)
> Hello,
> 
> Now that the OMAP3 supports the common clock framework, clock rate
> back-propagation is available for the ISP clocks. Instead of setting the
> cam_mclk parent clock rate to control the cam_mclk clock rate, we can mark the
> dpll4_m5x2_ck_3630 and cam_mclk clocks as supporting back-propagation, and set
> the cam_mclk rate directly. This simplifies the ISP clocks configuration.
>

I'm pleased to see this feature get used on OMAP.  Plus your driver gets
a negative diffstat :)

Reviewed-by: Mike Turquette <mturquette@linaro.org>
 
> Laurent Pinchart (2):
>   ARM: OMAP3: clock: Back-propagate rate change from cam_mclk to
>     dpll4_m5
>   omap3isp: Set cam_mclk rate directly
> 
>  arch/arm/mach-omap2/cclock3xxx_data.c |   10 +++++++++-
>  drivers/media/platform/omap3isp/isp.c |   18 ++----------------
>  drivers/media/platform/omap3isp/isp.h |    8 +++-----
>  3 files changed, 14 insertions(+), 22 deletions(-)
> 
> -- 
> Regards,
> 
> Laurent Pinchart

  parent reply	other threads:[~2013-01-15  1:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 13:43 [PATCH 0/2] OMAP3 ISP: Simplify clock usage Laurent Pinchart
2013-01-08 13:43 ` [PATCH 1/2] ARM: OMAP3: clock: Back-propagate rate change from cam_mclk to dpll4_m5 Laurent Pinchart
2013-01-08 13:43 ` [PATCH 2/2] omap3isp: Set cam_mclk rate directly Laurent Pinchart
2013-01-15  1:10 ` Mike Turquette [this message]
2013-01-21 13:35   ` [PATCH 0/2] OMAP3 ISP: Simplify clock usage Laurent Pinchart
2013-01-21 17:18     ` Tony Lindgren
2013-01-21 18:54       ` Laurent Pinchart
2013-01-21 19:04         ` Mike Turquette
2013-01-22  2:57         ` Paul Walmsley
2013-01-22 23:56           ` Laurent Pinchart
2013-01-19 17:27 ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130115011015.23734.75232@quantum \
    --to=mturquette@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).