From: Wolfram Sang <w.sang@pengutronix.de>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: ben-linux@fluff.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, balbi@ti.com
Subject: Re: [PATCH] i2c: omap: fix draining irq handling
Date: Wed, 23 Jan 2013 10:57:23 +0100 [thread overview]
Message-ID: <20130123095723.GF3767@nekote.pengutronix.de> (raw)
In-Reply-To: <1358707022-26477-1-git-send-email-aaro.koskinen@iki.fi>
On Sun, Jan 20, 2013 at 08:37:02PM +0200, Aaro Koskinen wrote:
> Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize
> exit path) changed the interrupt handler to exit early and complete
> the transfer after the draining IRQ is handled. As a result, the ARDY
> may not be cleared properly, and it may cause all future I2C transfers
> to timeout with "timeout waiting for bus ready". This is reproducible
> at least with N900 when twl4030_gpio makes a long write (> FIFO size)
> during the probe (http://marc.info/?l=linux-omap&m=135818882610432&w=2).
>
> The fix is to continue until we get ARDY interrupt that completes the
> transfer. Tested with 3.8-rc4 + N900: 20 boots in a row without errors;
> without the patch the problem triggers after few reboots.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applied to current and interpreted Felipe's comments as ack. Thanks!
prev parent reply other threads:[~2013-01-23 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 18:37 [PATCH] i2c: omap: fix draining irq handling Aaro Koskinen
2013-01-21 8:44 ` Felipe Balbi
2013-01-21 18:01 ` Aaro Koskinen
2013-01-21 18:27 ` Felipe Balbi
2013-01-23 9:57 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123095723.GF3767@nekote.pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).