From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Chen Gang <gang.chen@asianux.com>,
linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: Fix the use of uninitialized dma_lch_count
Date: Fri, 1 Feb 2013 14:40:32 -0800 [thread overview]
Message-ID: <20130201224032.GD22517@atomide.com> (raw)
In-Reply-To: <50EFF99B.7040602@ti.com>
* Santosh Shilimkar <santosh.shilimkar@ti.com> [130111 03:40]:
> On Friday 11 January 2013 11:09 AM, Chen Gang wrote:
> >
> > 'omap_dma_reserve_channels' when used is suppose to be from command.
> > so, it alreay has value before 1st call of omap_system_dma_probe.
> > and it will never be changed again during running (not from ioctl).
> >
> > but 'dma_lch_count' is zero before 1st call of omap_system_dma_probe.
> > so it will be failed for omap_dma_reserve_channels, when 1st call.
> >
> > so, need use 'd->lch_count' instead of 'dma_lch_count' for judging.
> >
> >Signed-off-by: Chen Gang <gang.chen@asianux.com>
> >Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >---
> Looks fine to me.
>
> Tony,
> If you are ok with the patch, can you pick this fix in your
> non-critical fixes branch ?
Yes applying thanks.
Tony
prev parent reply other threads:[~2013-02-01 22:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 10:29 [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels Chen Gang
2013-01-10 10:48 ` Santosh Shilimkar
2013-01-10 10:51 ` Santosh Shilimkar
2013-01-11 5:09 ` Chen Gang
2013-01-11 5:03 ` Chen Gang
2013-01-11 7:26 ` Santosh Shilimkar
2013-01-11 11:24 ` Chen Gang
2013-01-11 5:39 ` [PATCH] ARM: OMAP: Fix the use of uninitialized dma_lch_count Chen Gang
2013-01-11 11:38 ` Santosh Shilimkar
2013-02-01 22:40 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201224032.GD22517@atomide.com \
--to=tony@atomide.com \
--cc=gang.chen@asianux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).