From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data Date: Sat, 09 Feb 2013 14:15:44 +0000 Message-ID: <20130209141544.119593E30EC@localhost> References: <1355996651-17805-1-git-send-email-peter.ujfalusi@ti.com> <50EEBD8F.6040101@ti.com> Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:50913 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859Ab3BIOPs (ORCPT ); Sat, 9 Feb 2013 09:15:48 -0500 Received: by mail-wi0-f170.google.com with SMTP id hm11so1919111wib.3 for ; Sat, 09 Feb 2013 06:15:47 -0800 (PST) In-Reply-To: <50EEBD8F.6040101@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Peter Ujfalusi , Linus Walleij Cc: Michael Trimarchi , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org On Thu, 10 Jan 2013 14:09:35 +0100, Peter Ujfalusi wrote: > Hi Linus, > > On 01/10/2013 11:41 AM, Linus Walleij wrote: > > On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi wrote: > > > >> Use more coherent locking in the driver. Use bitfield to store the GPIO > >> direction and if the pin is configured as output store the status also in a > >> bitfiled. > >> In this way we can just look at these bitfields when we need information > >> about the pin status and only reach out to the chip when it is needed. > >> > >> Signed-off-by: Peter Ujfalusi > >> Acked-by: Linus Walleij > >> --- > >> Hi Grant, > >> > >> Changes sicne v2: > >> - Fixed the mutex_unlock found by Michael. > >> - Removed the debug prints addedd by v2 patch (remains from debugging) > >> - Removed one blank line between includes and the first comment section. > > > > Sorry Peter this must have been missed somehow. > > > > This does not apply to the current v3.8-rc3, could you respin > > this on top of Torvalds' tree? > > Grant applied the patch which this one depends on: > [1] https://patchwork.kernel.org/patch/1844511/ I had applied it, never pushed the tree out because I wasn't able to test my kernel tree for a couple of weeks due to travel. I saw the patch in Linus' tree and pulled it out of mine before I pushed it out. g.