* [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static'
@ 2013-02-06 9:24 Chen Gang
2013-02-06 9:36 ` Santosh Shilimkar
0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2013-02-06 9:24 UTC (permalink / raw)
To: Santosh Shilimkar, khilman, grant.likely, linus.walleij; +Cc: linux-omap
'const static ' is not a common order, better to use 'const static' instead.
building:
make EXTRA_CFLAGS=-W ARCH=arm
drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/gpio/gpio-omap.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f1fbedb2..159f5c5 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1476,19 +1476,19 @@ static struct omap_gpio_reg_offs omap4_gpio_regs = {
.fallingdetect = OMAP4_GPIO_FALLINGDETECT,
};
-const static struct omap_gpio_platform_data omap2_pdata = {
+static const struct omap_gpio_platform_data omap2_pdata = {
.regs = &omap2_gpio_regs,
.bank_width = 32,
.dbck_flag = false,
};
-const static struct omap_gpio_platform_data omap3_pdata = {
+static const struct omap_gpio_platform_data omap3_pdata = {
.regs = &omap2_gpio_regs,
.bank_width = 32,
.dbck_flag = true,
};
-const static struct omap_gpio_platform_data omap4_pdata = {
+static const struct omap_gpio_platform_data omap4_pdata = {
.regs = &omap4_gpio_regs,
.bank_width = 32,
.dbck_flag = true,
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static'
2013-02-06 9:24 [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static' Chen Gang
@ 2013-02-06 9:36 ` Santosh Shilimkar
2013-02-06 10:38 ` Chen Gang
0 siblings, 1 reply; 7+ messages in thread
From: Santosh Shilimkar @ 2013-02-06 9:36 UTC (permalink / raw)
To: Chen Gang; +Cc: Kevin Hilman, grant.likely, linus.walleij, linux-omap
On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote:
>
> 'const static ' is not a common order, better to use 'const static' instead.
You mean " use static const instead ", right ?
> building:
> make EXTRA_CFLAGS=-W ARCH=arm
>
> drivers/gpio/gpio-omap.c:1479:
> warning: 'static' is not at beginning of declaration
> drivers/gpio/gpio-omap.c:1485:
> warning: 'static' is not at beginning of declaration
> drivers/gpio/gpio-omap.c:1491:
> warning: 'static' is not at beginning of declaration
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
With change log fixed,
Acked-by: Santosh Shilimkar ,santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static'
2013-02-06 9:36 ` Santosh Shilimkar
@ 2013-02-06 10:38 ` Chen Gang
2013-02-06 10:41 ` Santosh Shilimkar
0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2013-02-06 10:38 UTC (permalink / raw)
To: Santosh Shilimkar; +Cc: Kevin Hilman, grant.likely, linus.walleij, linux-omap
于 2013年02月06日 17:36, Santosh Shilimkar 写道:
> On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote:
>> >
>> > 'const static ' is not a common order, better to use 'const static' instead.
> You mean " use static const instead ", right ?
>
oh, yes. it is my miswritten.
if necessary to send patch v2, please tell me.
thanks.
:-)
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static'
2013-02-06 10:38 ` Chen Gang
@ 2013-02-06 10:41 ` Santosh Shilimkar
2013-02-06 10:44 ` [PATCH v2] " Chen Gang
0 siblings, 1 reply; 7+ messages in thread
From: Santosh Shilimkar @ 2013-02-06 10:41 UTC (permalink / raw)
To: Chen Gang; +Cc: Kevin Hilman, grant.likely, linus.walleij, linux-omap
On Wednesday 06 February 2013 04:08 PM, Chen Gang wrote:
> 于 2013年02月06日 17:36, Santosh Shilimkar 写道:
>> On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote:
>>>>
>>>> 'const static ' is not a common order, better to use 'const static' instead.
>> You mean " use static const instead ", right ?
>>
>
> oh, yes. it is my miswritten.
>
> if necessary to send patch v2, please tell me.
>
Please do send updated version.
Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'
2013-02-06 10:41 ` Santosh Shilimkar
@ 2013-02-06 10:44 ` Chen Gang
2013-02-06 10:47 ` Santosh Shilimkar
0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2013-02-06 10:44 UTC (permalink / raw)
To: Santosh Shilimkar, Kevin Hilman, grant.likely, linus.walleij; +Cc: linux-omap
'const static ' is not a common order, better to use 'static const' instead.
building:
make EXTRA_CFLAGS=-W ARCH=arm
drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
drivers/gpio/gpio-omap.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f1fbedb2..159f5c5 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1476,19 +1476,19 @@ static struct omap_gpio_reg_offs omap4_gpio_regs = {
.fallingdetect = OMAP4_GPIO_FALLINGDETECT,
};
-const static struct omap_gpio_platform_data omap2_pdata = {
+static const struct omap_gpio_platform_data omap2_pdata = {
.regs = &omap2_gpio_regs,
.bank_width = 32,
.dbck_flag = false,
};
-const static struct omap_gpio_platform_data omap3_pdata = {
+static const struct omap_gpio_platform_data omap3_pdata = {
.regs = &omap2_gpio_regs,
.bank_width = 32,
.dbck_flag = true,
};
-const static struct omap_gpio_platform_data omap4_pdata = {
+static const struct omap_gpio_platform_data omap4_pdata = {
.regs = &omap4_gpio_regs,
.bank_width = 32,
.dbck_flag = true,
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'
2013-02-06 10:44 ` [PATCH v2] " Chen Gang
@ 2013-02-06 10:47 ` Santosh Shilimkar
2013-02-09 14:22 ` Grant Likely
0 siblings, 1 reply; 7+ messages in thread
From: Santosh Shilimkar @ 2013-02-06 10:47 UTC (permalink / raw)
To: Chen Gang; +Cc: Kevin Hilman, grant.likely, linus.walleij, linux-omap
On Wednesday 06 February 2013 04:14 PM, Chen Gang wrote:
>
> 'const static ' is not a common order, better to use 'static const' instead.
>
> building:
> make EXTRA_CFLAGS=-W ARCH=arm
>
> drivers/gpio/gpio-omap.c:1479:
> warning: 'static' is not at beginning of declaration
> drivers/gpio/gpio-omap.c:1485:
> warning: 'static' is not at beginning of declaration
> drivers/gpio/gpio-omap.c:1491:
> warning: 'static' is not at beginning of declaration
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
Thanks for update.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'
2013-02-06 10:47 ` Santosh Shilimkar
@ 2013-02-09 14:22 ` Grant Likely
0 siblings, 0 replies; 7+ messages in thread
From: Grant Likely @ 2013-02-09 14:22 UTC (permalink / raw)
To: Santosh Shilimkar, Chen Gang; +Cc: Kevin Hilman, linus.walleij, linux-omap
On Wed, 6 Feb 2013 16:17:24 +0530, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
> On Wednesday 06 February 2013 04:14 PM, Chen Gang wrote:
> >
> > 'const static ' is not a common order, better to use 'static const' instead.
> >
> > building:
> > make EXTRA_CFLAGS=-W ARCH=arm
> >
> > drivers/gpio/gpio-omap.c:1479:
> > warning: 'static' is not at beginning of declaration
> > drivers/gpio/gpio-omap.c:1485:
> > warning: 'static' is not at beginning of declaration
> > drivers/gpio/gpio-omap.c:1491:
> > warning: 'static' is not at beginning of declaration
> >
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > ---
> Thanks for update.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Applied, thanks.
g.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-09 14:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-06 9:24 [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static' Chen Gang
2013-02-06 9:36 ` Santosh Shilimkar
2013-02-06 10:38 ` Chen Gang
2013-02-06 10:41 ` Santosh Shilimkar
2013-02-06 10:44 ` [PATCH v2] " Chen Gang
2013-02-06 10:47 ` Santosh Shilimkar
2013-02-09 14:22 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).