From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] ARM: OMAP2+: clean up and standardize WFI handling for 3.9
Date: Mon, 11 Feb 2013 09:37:32 -0800 [thread overview]
Message-ID: <20130211173731.GO4801@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1302101726020.2672@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [130210 09:31]:
> Hi Tony
>
> On Sun, 10 Feb 2013, Tony Lindgren wrote:
>
> > * Paul Walmsley <paul@pwsan.com> [130208 09:31]:
> > >
> > > ----------------------------------------------------------------
> > > On OMAP2+ devices, standardize and clean up WFI entry and WFI blocking.
> > >
> > > Basic test logs are available here:
> > >
> > > http://www.pwsan.com/omap/testlogs/wfi_devel_a_3.9/20130208085027/
> >
> > Thanks pulled into omap-for-v3.9/pm-wfi. While merging this into
> > omap-for-v3.9/tmp-merge, got the following merge conlict. Maybe
> > take a look if it's correct merge?
>
> ...
>
> > }
> >
> > - omap2_sram_idle();
> > -
> > - pwrdm_set_next_pwrst(mpu_pwrdm, PWRDM_POWER_ON);
> > + /* WFI */
> > + asm("mcr p15, 0, %0, c7, c0, 4" : : "r" (zero) : "memory", "cc");
> > }
>
> The inline asm is intended to replace the omap2_sram_idle() call. I'd
> suggest:
>
> }
>
> /* WFI */
> asm("mcr p15, 0, %0, c7, c0, 4" : : "r" (zero) : "memory", "cc");
>
> pwrdm_set_next_pwrst(mpu_pwrdm, PWRDM_POWER_ON);
> }
>
> as the end product.
OK thanks.
This branch should probably have been based on your earlier PM branch
based on v3.8-rc5 that was already merged as omap-for-v3.9/pm-signed into
arm-soc for-next.
Now merging this branch based on v3.8-rc6 requires me to create a merge
base by merging the earlier branch with v3.8-rc6 and then resolving
the self-inflicted merge conflict in order for me to generate a pull request
without a non-trivial merge conflict. Just a bunch of extra hassle to
deal with with additional risk of merging things wrong. Anyways merging
into omap-for-v3.9/pm-wfi-take2.
Regards,
Tony
next prev parent reply other threads:[~2013-02-11 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 17:27 [GIT PULL] ARM: OMAP2+: clean up and standardize WFI handling for 3.9 Paul Walmsley
2013-02-10 17:08 ` Tony Lindgren
2013-02-10 17:28 ` Paul Walmsley
2013-02-11 17:37 ` Tony Lindgren [this message]
2013-02-11 17:45 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211173731.GO4801@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox