linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: Display related board specific boot args
Date: Fri, 22 Mar 2013 08:18:39 -0700	[thread overview]
Message-ID: <20130322151838.GB25575@atomide.com> (raw)
In-Reply-To: <514C1599.7080803@ti.com>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [130322 01:30]:
> Hi Tony,
> 
> As you probably know, Overo is a very basic omap board to which you can
> attach different add-on modules, like LCD module. In the current overo
> board file we always add multiple LCD devices, of which the user should
> only use one (the one on his module). This model of allowing multiple
> LCD devices on the same video bus is causing headaches in the dss land,
> and I'm removing support for it.

OK yes sounds like they should be all selectable, and only the selected
one gets initialized.
 
> So what we should do is add only the LCD device that you actually have
> attached. With DT this will probably be handled with separate dts files,
> depending on the add-on module.
> 
> How should this be handled with board files? Is it ok to add a board
> specific kernel boot argument, parsed in the board file, which tells the
> add-on board?

At this point I'd stay away adding any kind of custom handling to the
board-*.c files as that will make the task of removing them harder. And
a kernel boot argument is something we'd have to support in the future.
So if something gets added, it should be a Linux generic boot argument.

Some of these add on boards can be detected over i2c, but it seems as
DT is the way to go in the long run in this case.
 
> We have similar situation in some other boards also.

Yeah. There's the capebus coming that might even allow hotplugging
some of these add on boards eventually.

How about just make PANEL_LGPHILIPS_LB035Q02 depends on !PANEL_XYZ_DPI
in drivers/video/omap2/displays/Kconfig and add some comments for now?

That way people can still select LB035Q02 but not for generic
configurations.

Regards,

Tony

  reply	other threads:[~2013-03-22 15:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  8:26 Display related board specific boot args Tomi Valkeinen
2013-03-22 15:18 ` Tony Lindgren [this message]
2013-03-22 15:29   ` Tomi Valkeinen
2013-03-22 15:36     ` Tony Lindgren
2013-03-22 16:00       ` Andy Gross
2013-03-25 10:16       ` Overo expansion board selection with Kconfig (Was: Re: Display related board specific boot args) Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130322151838.GB25575@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).