From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH-V2] ARM: AM33XX: Add missing .clkdm_name to clkdiv32k_ick clock Date: Wed, 27 Mar 2013 13:19:53 -0700 Message-ID: <20130327201952.GI10155@atomide.com> References: <1364378666-23641-1-git-send-email-hvaibhav@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:14680 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753994Ab3C0UT5 (ORCPT ); Wed, 27 Mar 2013 16:19:57 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Vaibhav Hiremath , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rajendra Nayak * Paul Walmsley [130327 10:49]: > On Wed, 27 Mar 2013, Vaibhav Hiremath wrote: > > > It is required to enable respective clock-domain before > > enabling any clock/module inside that clock-domain. > > > > During common-clock migration, .clkdm_name field got missed > > for "clkdiv32k_ick" clock, which leaves "clk_24mhz_clkdm" > > unused; so it will be disabled even if childs of this clock-domain > > is enabled, which keeps child modules in idle mode. > > > > This fixes the kernel crash observed on AM335xEVM-SK platform, > > where clkdiv32_ick clock is being used as a gpio debounce clock > > and since clkdiv32k_ick is in idle mode it leads to below crash - > > > > Crash Log: > > ========== > > [ 2.598347] Unhandled fault: external abort on non-linefetch (0x1028) at > > 0xfa1ac150 > > [ 2.606434] Internal error: : 1028 [#1] SMP ARM > > [ 2.611207] Modules linked in: > > [ 2.614449] CPU: 0 Not tainted (3.8.4-01382-g1f449cd-dirty #4) > > [ 2.620973] PC is at _set_gpio_debounce+0x60/0x104 > > [ 2.626025] LR is at clk_enable+0x30/0x3c > > > > Signed-off-by: Vaibhav Hiremath > > Cc: Tony Lindgren > > Cc: Paul Walmsley > > Cc: Rajendra Nayak > > Acked-by: Paul Walmsley > > Tony, if it isn't too late, could this one be added to your 3.9-rc fixes > series? Just sent the previous ones, I'll add this into omap-for-v3.9-rc4/fixes. Regards, Tony