* [PATCH] RX-51: Fix probe order of SPI devices
@ 2013-03-31 10:09 Pali Rohár
[not found] ` <20130331105222.GA22426@earth.universe>
0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2013-03-31 10:09 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, linux-kernel, Joni Lapilainen, Pali Rohár
From: Joni Lapilainen <joni.lapilainen@gmail.com>
Without this patch LCD panel on Nokia RX-51 is still black
Signed-off-by: Joni Lapilainen <joni.lapilainen@gmail.com>
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index b09b5da..03290b9 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -91,8 +91,8 @@
/* list all spi devices here */
enum {
RX51_SPI_WL1251,
- RX51_SPI_MIPID, /* LCD panel */
RX51_SPI_TSC2005, /* Touch Controller */
+ RX51_SPI_MIPID, /* LCD panel */
};
static struct wl12xx_platform_data wl1251_pdata;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <20130331105222.GA22426@earth.universe>]
* Re: [PATCH] RX-51: Fix probe order of SPI devices [not found] ` <20130331105222.GA22426@earth.universe> @ 2013-03-31 11:18 ` Pali Rohár 2013-04-02 16:31 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Pali Rohár @ 2013-03-31 11:18 UTC (permalink / raw) To: Sebastian Reichel Cc: Tony Lindgren, linux-omap, linux-kernel, Joni Lapilainen, Aaro Koskinen [-- Attachment #1: Type: Text/Plain, Size: 708 bytes --] On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > Without this patch LCD panel on Nokia RX-51 is still black > > > > Signed-off-by: Joni Lapilainen <joni.lapilainen@gmail.com> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > Tested-by: Sebastian Reichel <sre@debian.org> > > Please note, that this patch has actually been proposed by > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago [0]. > > [0] > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 > > -- Sebastian CCing Aaro. -- Pali Rohár pali.rohar@gmail.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RX-51: Fix probe order of SPI devices 2013-03-31 11:18 ` Pali Rohár @ 2013-04-02 16:31 ` Tony Lindgren 2013-04-10 14:15 ` Pali Rohár 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2013-04-02 16:31 UTC (permalink / raw) To: Pali Rohár Cc: Sebastian Reichel, linux-omap, linux-kernel, Joni Lapilainen, Aaro Koskinen * Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > Without this patch LCD panel on Nokia RX-51 is still black > > > > > > Signed-off-by: Joni Lapilainen <joni.lapilainen@gmail.com> > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > Please note, that this patch has actually been proposed by > > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago [0]. > > > > [0] > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 > > > > -- Sebastian > > CCing Aaro. Any ideas why this is happening? Is the touch screen controller somehow pulling one of the SPI lines before it's reset? I don't think there's any other connection between the LCD and touch controller besides the SPI lines? In any case there should be something in the description why this is needed.. Regards, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RX-51: Fix probe order of SPI devices 2013-04-02 16:31 ` Tony Lindgren @ 2013-04-10 14:15 ` Pali Rohár 2013-04-10 17:00 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Pali Rohár @ 2013-04-10 14:15 UTC (permalink / raw) To: Tony Lindgren Cc: Sebastian Reichel, linux-omap, linux-kernel, Joni Lapilainen, Aaro Koskinen [-- Attachment #1: Type: Text/Plain, Size: 1395 bytes --] On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote: > * Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > > > Without this patch LCD panel on Nokia RX-51 is still > > > > black > > > > > > > > Signed-off-by: Joni Lapilainen > > > > <joni.lapilainen@gmail.com> Signed-off-by: Pali Rohár > > > > <pali.rohar@gmail.com> > > > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > > > Please note, that this patch has actually been proposed by > > > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago > > > [0]. > > > > > > [0] > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172 > > > 9 > > > > > > -- Sebastian > > > > CCing Aaro. > > Any ideas why this is happening? > > Is the touch screen controller somehow pulling one of the SPI > lines before it's reset? I don't think there's any other > connection between the LCD and touch controller besides the > SPI lines? > > In any case there should be something in the description why > this is needed.. > > Regards, > > Tony Hi Tony, look at this Aaro's email: http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 -- Pali Rohár pali.rohar@gmail.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RX-51: Fix probe order of SPI devices 2013-04-10 14:15 ` Pali Rohár @ 2013-04-10 17:00 ` Tony Lindgren 2013-04-24 12:23 ` Pali Rohár 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2013-04-10 17:00 UTC (permalink / raw) To: Pali Rohár Cc: Sebastian Reichel, linux-omap, linux-kernel, Joni Lapilainen, Aaro Koskinen * Pali Rohár <pali.rohar@gmail.com> [130410 07:20]: > On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote: > > * Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > > > > > Without this patch LCD panel on Nokia RX-51 is still > > > > > black > > > > > > > > > > Signed-off-by: Joni Lapilainen > > > > > <joni.lapilainen@gmail.com> Signed-off-by: Pali Rohár > > > > > <pali.rohar@gmail.com> > > > > > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > > > > > Please note, that this patch has actually been proposed by > > > > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago > > > > [0]. > > > > > > > > [0] > > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172 > > > > 9 > > > > > > > > -- Sebastian > > > > > > CCing Aaro. > > > > Any ideas why this is happening? > > > > Is the touch screen controller somehow pulling one of the SPI > > lines before it's reset? I don't think there's any other > > connection between the LCD and touch controller besides the > > SPI lines? > > > > In any case there should be something in the description why > > this is needed.. > > > > Regards, > > > > Tony > > Hi Tony, look at this Aaro's email: > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 OK can we have that summarized in the patch description please? Regards, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RX-51: Fix probe order of SPI devices 2013-04-10 17:00 ` Tony Lindgren @ 2013-04-24 12:23 ` Pali Rohár 0 siblings, 0 replies; 6+ messages in thread From: Pali Rohár @ 2013-04-24 12:23 UTC (permalink / raw) To: Aaro Koskinen Cc: Tony Lindgren, Sebastian Reichel, linux-omap, linux-kernel, Joni Lapilainen [-- Attachment #1: Type: Text/Plain, Size: 1852 bytes --] On Wednesday 10 April 2013 19:00:05 Tony Lindgren wrote: > * Pali Rohár <pali.rohar@gmail.com> [130410 07:20]: > > On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote: > > > * Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > > > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > > > > > > > Without this patch LCD panel on Nokia RX-51 is still > > > > > > black > > > > > > > > > > > > Signed-off-by: Joni Lapilainen > > > > > > <joni.lapilainen@gmail.com> Signed-off-by: Pali > > > > > > Rohár <pali.rohar@gmail.com> > > > > > > > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > > > > > > > Please note, that this patch has actually been > > > > > proposed by Aaro Koskinen <aaro.koskinen@iki.fi> > > > > > quite some time ago [0]. > > > > > > > > > > [0] > > > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/ > > > > > 8172 9 > > > > > > > > > > -- Sebastian > > > > > > > > CCing Aaro. > > > > > > Any ideas why this is happening? > > > > > > Is the touch screen controller somehow pulling one of the > > > SPI lines before it's reset? I don't think there's any > > > other connection between the LCD and touch controller > > > besides the SPI lines? > > > > > > In any case there should be something in the description > > > why this is needed.. > > > > > > Regards, > > > > > > Tony > > > > Hi Tony, look at this Aaro's email: > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 > > OK can we have that summarized in the patch description > please? > > Regards, > > Tony Aaro, this patch is yours, can you resend it with description? -- Pali Rohár pali.rohar@gmail.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-24 12:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-31 10:09 [PATCH] RX-51: Fix probe order of SPI devices Pali Rohár
[not found] ` <20130331105222.GA22426@earth.universe>
2013-03-31 11:18 ` Pali Rohár
2013-04-02 16:31 ` Tony Lindgren
2013-04-10 14:15 ` Pali Rohár
2013-04-10 17:00 ` Tony Lindgren
2013-04-24 12:23 ` Pali Rohár
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).