Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 1433 bytes --]

On Sunday 24 March 2013 15:03:29 Pali Rohár wrote:
> On Saturday 02 March 2013 23:23:05 Pali Rohár wrote:
> > On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > > Driver twl4030-madc has hardcoded channel types (10 -
> > > battery current, 1 - battery temperature) and also
> > > conversation data in variable twl4030_divider_ratios.
> > > These hardcoded channels are incorrect for Nokia RX-51
> > > board (where is channel 0 - battery temperature).
> > > 
> > > For Nokia RX-51 there is rx51_battery power_supply driver
> > > which reporting battery information via
> > > twl4030_madc_conversion. But this driver needs raw values
> > > (not converted via some hardcoded functions). So this
> > > patch adding new parameter "raw" to struct
> > > twl4030_madc_request which tell twl4030-madc driver to
> > > not convert values, but rather return raw.
> > > 
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > ---
> > > 
> > >  drivers/mfd/twl4030-madc.c       |   14 ++++++++++----
> > >  include/linux/i2c/twl4030-madc.h |    2 ++
> > >  2 files changed, 12 insertions(+), 4 deletions(-)
> > 
> > Hello, can somebody review this twl4030-madc patch?
> 
> Bump.
> 
> Can some of mfd maintainers look at this patch and include it
> to mfd tree? It is needed for rx51_battery power supply
> driver.

CCing Tony, can you look at this patch?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

[Tony Lindgren]

* Pali Rohár <pali.rohar@gmail.com> [130404 02:37]:
> On Sunday 24 March 2013 15:03:29 Pali Rohár wrote:
> > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote:
> > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > > > Driver twl4030-madc has hardcoded channel types (10 -
> > > > battery current, 1 - battery temperature) and also
> > > > conversation data in variable twl4030_divider_ratios.
> > > > These hardcoded channels are incorrect for Nokia RX-51
> > > > board (where is channel 0 - battery temperature).
> > > > 
> > > > For Nokia RX-51 there is rx51_battery power_supply driver
> > > > which reporting battery information via
> > > > twl4030_madc_conversion. But this driver needs raw values
> > > > (not converted via some hardcoded functions). So this
> > > > patch adding new parameter "raw" to struct
> > > > twl4030_madc_request which tell twl4030-madc driver to
> > > > not convert values, but rather return raw.
> > > > 
> > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > > ---
> > > > 
> > > >  drivers/mfd/twl4030-madc.c       |   14 ++++++++++----
> > > >  include/linux/i2c/twl4030-madc.h |    2 ++
> > > >  2 files changed, 12 insertions(+), 4 deletions(-)
> > > 
> > > Hello, can somebody review this twl4030-madc patch?
> > 
> > Bump.
> > 
> > Can some of mfd maintainers look at this patch and include it
> > to mfd tree? It is needed for rx51_battery power supply
> > driver.
> 
> CCing Tony, can you look at this patch?

Sorry for the delay in replying, I've been going through my
inbox for the merge window and noticed this.

I suggest resend with Peter Ujfalusi cc:d as he is the de-facto
twl/tps maintainer and expert by now.

Regards,

Tony

Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 1989 bytes --]

On Monday 08 April 2013 20:15:24 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [130404 02:37]:
> > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote:
> > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote:
> > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > > > > Driver twl4030-madc has hardcoded channel types (10 -
> > > > > battery current, 1 - battery temperature) and also
> > > > > conversation data in variable twl4030_divider_ratios.
> > > > > These hardcoded channels are incorrect for Nokia RX-51
> > > > > board (where is channel 0 - battery temperature).
> > > > > 
> > > > > For Nokia RX-51 there is rx51_battery power_supply
> > > > > driver which reporting battery information via
> > > > > twl4030_madc_conversion. But this driver needs raw
> > > > > values (not converted via some hardcoded functions).
> > > > > So this patch adding new parameter "raw" to struct
> > > > > twl4030_madc_request which tell twl4030-madc driver to
> > > > > not convert values, but rather return raw.
> > > > > 
> > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > > > ---
> > > > > 
> > > > >  drivers/mfd/twl4030-madc.c       |   14
> > > > >  ++++++++++---- include/linux/i2c/twl4030-madc.h |   
> > > > >  2 ++
> > > > >  2 files changed, 12 insertions(+), 4 deletions(-)
> > > > 
> > > > Hello, can somebody review this twl4030-madc patch?
> > > 
> > > Bump.
> > > 
> > > Can some of mfd maintainers look at this patch and include
> > > it to mfd tree? It is needed for rx51_battery power
> > > supply driver.
> > 
> > CCing Tony, can you look at this patch?
> 
> Sorry for the delay in replying, I've been going through my
> inbox for the merge window and noticed this.
> 
> I suggest resend with Peter Ujfalusi cc:d as he is the
> de-facto twl/tps maintainer and expert by now.
> 
> Regards,
> 
> Tony

Ok, both patches are now in mfd-next tree.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

[Tony Lindgren]

* Pali Rohár <pali.rohar@gmail.com> [130410 07:17]:
> On Monday 08 April 2013 20:15:24 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [130404 02:37]:
> > > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote:
> > > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote:
> > > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > > > > > Driver twl4030-madc has hardcoded channel types (10 -
> > > > > > battery current, 1 - battery temperature) and also
> > > > > > conversation data in variable twl4030_divider_ratios.
> > > > > > These hardcoded channels are incorrect for Nokia RX-51
> > > > > > board (where is channel 0 - battery temperature).
> > > > > > 
> > > > > > For Nokia RX-51 there is rx51_battery power_supply
> > > > > > driver which reporting battery information via
> > > > > > twl4030_madc_conversion. But this driver needs raw
> > > > > > values (not converted via some hardcoded functions).
> > > > > > So this patch adding new parameter "raw" to struct
> > > > > > twl4030_madc_request which tell twl4030-madc driver to
> > > > > > not convert values, but rather return raw.
> > > > > > 
> > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > > > > ---
> > > > > > 
> > > > > >  drivers/mfd/twl4030-madc.c       |   14
> > > > > >  ++++++++++---- include/linux/i2c/twl4030-madc.h |   
> > > > > >  2 ++
> > > > > >  2 files changed, 12 insertions(+), 4 deletions(-)
> > > > > 
> > > > > Hello, can somebody review this twl4030-madc patch?
> > > > 
> > > > Bump.
> > > > 
> > > > Can some of mfd maintainers look at this patch and include
> > > > it to mfd tree? It is needed for rx51_battery power
> > > > supply driver.
> > > 
> > > CCing Tony, can you look at this patch?
> > 
> > Sorry for the delay in replying, I've been going through my
> > inbox for the merge window and noticed this.
> > 
> > I suggest resend with Peter Ujfalusi cc:d as he is the
> > de-facto twl/tps maintainer and expert by now.
> > 
> > Regards,
> > 
> > Tony
> 
> Ok, both patches are now in mfd-next tree.

Great thanks!

Tony