* Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion [not found] ` <201303241503.29912@pali> @ 2013-04-04 9:32 ` Pali Rohár 2013-04-08 18:15 ` Tony Lindgren 0 siblings, 1 reply; 4+ messages in thread From: Pali Rohár @ 2013-04-04 9:32 UTC (permalink / raw) To: linux-kernel Cc: Samuel Ortiz, Anton Vorontsov, Keerthy, Kyle Manna, Tony Lindgren, linux-omap [-- Attachment #1: Type: Text/Plain, Size: 1433 bytes --] On Sunday 24 March 2013 15:03:29 Pali Rohár wrote: > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote: > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote: > > > Driver twl4030-madc has hardcoded channel types (10 - > > > battery current, 1 - battery temperature) and also > > > conversation data in variable twl4030_divider_ratios. > > > These hardcoded channels are incorrect for Nokia RX-51 > > > board (where is channel 0 - battery temperature). > > > > > > For Nokia RX-51 there is rx51_battery power_supply driver > > > which reporting battery information via > > > twl4030_madc_conversion. But this driver needs raw values > > > (not converted via some hardcoded functions). So this > > > patch adding new parameter "raw" to struct > > > twl4030_madc_request which tell twl4030-madc driver to > > > not convert values, but rather return raw. > > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > --- > > > > > > drivers/mfd/twl4030-madc.c | 14 ++++++++++---- > > > include/linux/i2c/twl4030-madc.h | 2 ++ > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > > > Hello, can somebody review this twl4030-madc patch? > > Bump. > > Can some of mfd maintainers look at this patch and include it > to mfd tree? It is needed for rx51_battery power supply > driver. CCing Tony, can you look at this patch? -- Pali Rohár pali.rohar@gmail.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion 2013-04-04 9:32 ` [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár @ 2013-04-08 18:15 ` Tony Lindgren 2013-04-10 14:12 ` Pali Rohár 0 siblings, 1 reply; 4+ messages in thread From: Tony Lindgren @ 2013-04-08 18:15 UTC (permalink / raw) To: Pali Rohár Cc: linux-kernel, Samuel Ortiz, Anton Vorontsov, Keerthy, Kyle Manna, linux-omap * Pali Rohár <pali.rohar@gmail.com> [130404 02:37]: > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote: > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote: > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote: > > > > Driver twl4030-madc has hardcoded channel types (10 - > > > > battery current, 1 - battery temperature) and also > > > > conversation data in variable twl4030_divider_ratios. > > > > These hardcoded channels are incorrect for Nokia RX-51 > > > > board (where is channel 0 - battery temperature). > > > > > > > > For Nokia RX-51 there is rx51_battery power_supply driver > > > > which reporting battery information via > > > > twl4030_madc_conversion. But this driver needs raw values > > > > (not converted via some hardcoded functions). So this > > > > patch adding new parameter "raw" to struct > > > > twl4030_madc_request which tell twl4030-madc driver to > > > > not convert values, but rather return raw. > > > > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > > --- > > > > > > > > drivers/mfd/twl4030-madc.c | 14 ++++++++++---- > > > > include/linux/i2c/twl4030-madc.h | 2 ++ > > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > > > > > Hello, can somebody review this twl4030-madc patch? > > > > Bump. > > > > Can some of mfd maintainers look at this patch and include it > > to mfd tree? It is needed for rx51_battery power supply > > driver. > > CCing Tony, can you look at this patch? Sorry for the delay in replying, I've been going through my inbox for the merge window and noticed this. I suggest resend with Peter Ujfalusi cc:d as he is the de-facto twl/tps maintainer and expert by now. Regards, Tony ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion 2013-04-08 18:15 ` Tony Lindgren @ 2013-04-10 14:12 ` Pali Rohár 2013-04-10 17:00 ` Tony Lindgren 0 siblings, 1 reply; 4+ messages in thread From: Pali Rohár @ 2013-04-10 14:12 UTC (permalink / raw) To: Tony Lindgren Cc: linux-kernel, Samuel Ortiz, Anton Vorontsov, Keerthy, Kyle Manna, linux-omap [-- Attachment #1: Type: Text/Plain, Size: 1989 bytes --] On Monday 08 April 2013 20:15:24 Tony Lindgren wrote: > * Pali Rohár <pali.rohar@gmail.com> [130404 02:37]: > > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote: > > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote: > > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote: > > > > > Driver twl4030-madc has hardcoded channel types (10 - > > > > > battery current, 1 - battery temperature) and also > > > > > conversation data in variable twl4030_divider_ratios. > > > > > These hardcoded channels are incorrect for Nokia RX-51 > > > > > board (where is channel 0 - battery temperature). > > > > > > > > > > For Nokia RX-51 there is rx51_battery power_supply > > > > > driver which reporting battery information via > > > > > twl4030_madc_conversion. But this driver needs raw > > > > > values (not converted via some hardcoded functions). > > > > > So this patch adding new parameter "raw" to struct > > > > > twl4030_madc_request which tell twl4030-madc driver to > > > > > not convert values, but rather return raw. > > > > > > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > > > --- > > > > > > > > > > drivers/mfd/twl4030-madc.c | 14 > > > > > ++++++++++---- include/linux/i2c/twl4030-madc.h | > > > > > 2 ++ > > > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > > > > > > > Hello, can somebody review this twl4030-madc patch? > > > > > > Bump. > > > > > > Can some of mfd maintainers look at this patch and include > > > it to mfd tree? It is needed for rx51_battery power > > > supply driver. > > > > CCing Tony, can you look at this patch? > > Sorry for the delay in replying, I've been going through my > inbox for the merge window and noticed this. > > I suggest resend with Peter Ujfalusi cc:d as he is the > de-facto twl/tps maintainer and expert by now. > > Regards, > > Tony Ok, both patches are now in mfd-next tree. -- Pali Rohár pali.rohar@gmail.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion 2013-04-10 14:12 ` Pali Rohár @ 2013-04-10 17:00 ` Tony Lindgren 0 siblings, 0 replies; 4+ messages in thread From: Tony Lindgren @ 2013-04-10 17:00 UTC (permalink / raw) To: Pali Rohár Cc: linux-kernel, Samuel Ortiz, Anton Vorontsov, Keerthy, Kyle Manna, linux-omap * Pali Rohár <pali.rohar@gmail.com> [130410 07:17]: > On Monday 08 April 2013 20:15:24 Tony Lindgren wrote: > > * Pali Rohár <pali.rohar@gmail.com> [130404 02:37]: > > > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote: > > > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote: > > > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote: > > > > > > Driver twl4030-madc has hardcoded channel types (10 - > > > > > > battery current, 1 - battery temperature) and also > > > > > > conversation data in variable twl4030_divider_ratios. > > > > > > These hardcoded channels are incorrect for Nokia RX-51 > > > > > > board (where is channel 0 - battery temperature). > > > > > > > > > > > > For Nokia RX-51 there is rx51_battery power_supply > > > > > > driver which reporting battery information via > > > > > > twl4030_madc_conversion. But this driver needs raw > > > > > > values (not converted via some hardcoded functions). > > > > > > So this patch adding new parameter "raw" to struct > > > > > > twl4030_madc_request which tell twl4030-madc driver to > > > > > > not convert values, but rather return raw. > > > > > > > > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > > > > --- > > > > > > > > > > > > drivers/mfd/twl4030-madc.c | 14 > > > > > > ++++++++++---- include/linux/i2c/twl4030-madc.h | > > > > > > 2 ++ > > > > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > > > > > > > > > Hello, can somebody review this twl4030-madc patch? > > > > > > > > Bump. > > > > > > > > Can some of mfd maintainers look at this patch and include > > > > it to mfd tree? It is needed for rx51_battery power > > > > supply driver. > > > > > > CCing Tony, can you look at this patch? > > > > Sorry for the delay in replying, I've been going through my > > inbox for the merge window and noticed this. > > > > I suggest resend with Peter Ujfalusi cc:d as he is the > > de-facto twl/tps maintainer and expert by now. > > > > Regards, > > > > Tony > > Ok, both patches are now in mfd-next tree. Great thanks! Tony ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-10 17:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1360969010-8571-1-git-send-email-pali.rohar@gmail.com>
[not found] ` <201303022323.06091@pali>
[not found] ` <201303241503.29912@pali>
2013-04-04 9:32 ` [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-04-08 18:15 ` Tony Lindgren
2013-04-10 14:12 ` Pali Rohár
2013-04-10 17:00 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).