From: Tony Lindgren <tony@atomide.com>
To: Andrew Chew <achew@nvidia.com>
Cc: peter.ujfalusi@ti.com, thierry.reding@avionic-design.de,
acourbot@nvidia.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH V3 1/2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight
Date: Mon, 8 Apr 2013 14:46:24 -0700 [thread overview]
Message-ID: <20130408214624.GZ10155@atomide.com> (raw)
In-Reply-To: <1363214006-10662-2-git-send-email-achew@nvidia.com>
* Andrew Chew <achew@nvidia.com> [130313 15:37]:
> The pwm-backlight driver now takes a mandatory regulator that is gotten
> during driver probe. Initialize a dummy regulator to satisfy this
> requirement.
>
> Signed-off-by: Andrew Chew <achew@nvidia.com>
> ---
> Changed the device name of the backlight regulator supply to "pwm-backlight",
> per Peter's comment.
>
> Changed the name of the regulator to "backlight-enable", per Thierry's
> suggestion.
Thanks applying into omap-for-v3.10/board. Note that I'm not taking the
second one, that should be resent to the related driver maintainers.
You can get that list by running scripts/get_maintainer.pl against it.
Regards,
Tony
> arch/arm/mach-omap2/board-4430sdp.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index 35f3ad0..a01a39a 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -291,6 +291,10 @@ static struct platform_device sdp4430_leds_pwm = {
> },
> };
>
> +/* Dummy regulator for pwm-backlight driver */
> +static struct regulator_consumer_supply backlight_supply =
> + REGULATOR_SUPPLY("enable", "pwm-backlight");
> +
> static struct platform_pwm_backlight_data sdp4430_backlight_data = {
> .max_brightness = 127,
> .dft_brightness = 127,
> @@ -718,6 +722,8 @@ static void __init omap_4430sdp_init(void)
>
> omap4_i2c_init();
> omap_sfh7741prox_init();
> + regulator_register_always_on(-1, "backlight-enable",
> + &backlight_supply, 1, 0);
> platform_add_devices(sdp4430_devices, ARRAY_SIZE(sdp4430_devices));
> omap_serial_init();
> omap_sdrc_init(NULL, NULL);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-04-08 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:33 [PATCH V3 0/2] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-13 22:33 ` [PATCH V3 1/2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight Andrew Chew
2013-04-08 21:46 ` Tony Lindgren [this message]
2013-04-08 21:56 ` Thierry Reding
2013-04-08 22:16 ` Tony Lindgren
2013-04-09 7:56 ` Thierry Reding
2013-04-09 16:40 ` Tony Lindgren
2013-04-09 19:40 ` Thierry Reding
2013-04-09 20:17 ` Tony Lindgren
2013-04-09 20:57 ` Thierry Reding
2013-04-09 22:27 ` Tony Lindgren
2013-03-13 22:33 ` [PATCH V3 2/2] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-14 8:44 ` [PATCH V3 0/2] Add mandatory regulator for all users of pwm-backlight Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408214624.GZ10155@atomide.com \
--to=tony@atomide.com \
--cc=achew@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).