From: Tony Lindgren <tony@atomide.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Andrew Chew <achew@nvidia.com>,
peter.ujfalusi@ti.com, acourbot@nvidia.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH V3 1/2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight
Date: Mon, 8 Apr 2013 15:16:57 -0700 [thread overview]
Message-ID: <20130408221657.GC10155@atomide.com> (raw)
In-Reply-To: <20130408215616.GA25124@avionic-0098.mockup.avionic-design.de>
* Thierry Reding <thierry.reding@avionic-design.de> [130408 15:01]:
> On Mon, Apr 08, 2013 at 02:46:24PM -0700, Tony Lindgren wrote:
> > * Andrew Chew <achew@nvidia.com> [130313 15:37]:
> > > The pwm-backlight driver now takes a mandatory regulator that is gotten
> > > during driver probe. Initialize a dummy regulator to satisfy this
> > > requirement.
> > >
> > > Signed-off-by: Andrew Chew <achew@nvidia.com>
> > > ---
> > > Changed the device name of the backlight regulator supply to "pwm-backlight",
> > > per Peter's comment.
> > >
> > > Changed the name of the regulator to "backlight-enable", per Thierry's
> > > suggestion.
> >
> > Thanks applying into omap-for-v3.10/board. Note that I'm not taking the
> > second one, that should be resent to the related driver maintainers.
> > You can get that list by running scripts/get_maintainer.pl against it.
>
> The plan was to take these all through one tree, preferably the PWM tree
> because it's all PWM related and the pwm-backlight change will go
> through that tree as well. Technically these individual patches can be
> applied as is and aren't harmful, but keeping track of the dependencies
> might be difficult if they go in via separate trees.
Registering the regulator alone should not do anything. Also the driver
should do the right thing if the regulator is not yet registered.
Can you please check your driver patch so the driver won't do anything
if the regulator is not (yet) registered and repost it alone as I've
already applied the board-*.c change.
The reason why we want to do queue these patches separately is to cut
away the dependency between drivers and the core arch/arm changes.
Otherwise we'll end up with pointless merge conflicts as we've seen
earlier several times with the USB patches for example.
Regards,
Tony
next prev parent reply other threads:[~2013-04-08 22:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:33 [PATCH V3 0/2] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-13 22:33 ` [PATCH V3 1/2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight Andrew Chew
2013-04-08 21:46 ` Tony Lindgren
2013-04-08 21:56 ` Thierry Reding
2013-04-08 22:16 ` Tony Lindgren [this message]
2013-04-09 7:56 ` Thierry Reding
2013-04-09 16:40 ` Tony Lindgren
2013-04-09 19:40 ` Thierry Reding
2013-04-09 20:17 ` Tony Lindgren
2013-04-09 20:57 ` Thierry Reding
2013-04-09 22:27 ` Tony Lindgren
2013-03-13 22:33 ` [PATCH V3 2/2] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-14 8:44 ` [PATCH V3 0/2] Add mandatory regulator for all users of pwm-backlight Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408221657.GC10155@atomide.com \
--to=tony@atomide.com \
--cc=achew@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).