From: "Pali Rohár" <pali.rohar@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Anton Vorontsov <cbou@mail.ru>, Keerthy <j-keerthy@ti.com>,
Kyle Manna <kyle@kylemanna.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion
Date: Wed, 10 Apr 2013 16:12:51 +0200 [thread overview]
Message-ID: <201304101612.51620@pali> (raw)
In-Reply-To: <20130408181524.GU10155@atomide.com>
[-- Attachment #1: Type: Text/Plain, Size: 1989 bytes --]
On Monday 08 April 2013 20:15:24 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [130404 02:37]:
> > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote:
> > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote:
> > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > > > > Driver twl4030-madc has hardcoded channel types (10 -
> > > > > battery current, 1 - battery temperature) and also
> > > > > conversation data in variable twl4030_divider_ratios.
> > > > > These hardcoded channels are incorrect for Nokia RX-51
> > > > > board (where is channel 0 - battery temperature).
> > > > >
> > > > > For Nokia RX-51 there is rx51_battery power_supply
> > > > > driver which reporting battery information via
> > > > > twl4030_madc_conversion. But this driver needs raw
> > > > > values (not converted via some hardcoded functions).
> > > > > So this patch adding new parameter "raw" to struct
> > > > > twl4030_madc_request which tell twl4030-madc driver to
> > > > > not convert values, but rather return raw.
> > > > >
> > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > > > ---
> > > > >
> > > > > drivers/mfd/twl4030-madc.c | 14
> > > > > ++++++++++---- include/linux/i2c/twl4030-madc.h |
> > > > > 2 ++
> > > > > 2 files changed, 12 insertions(+), 4 deletions(-)
> > > >
> > > > Hello, can somebody review this twl4030-madc patch?
> > >
> > > Bump.
> > >
> > > Can some of mfd maintainers look at this patch and include
> > > it to mfd tree? It is needed for rx51_battery power
> > > supply driver.
> >
> > CCing Tony, can you look at this patch?
>
> Sorry for the delay in replying, I've been going through my
> inbox for the merge window and noticed this.
>
> I suggest resend with Peter Ujfalusi cc:d as he is the
> de-facto twl/tps maintainer and expert by now.
>
> Regards,
>
> Tony
Ok, both patches are now in mfd-next tree.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-04-10 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1360969010-8571-1-git-send-email-pali.rohar@gmail.com>
[not found] ` <201303022323.06091@pali>
[not found] ` <201303241503.29912@pali>
2013-04-04 9:32 ` [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-04-08 18:15 ` Tony Lindgren
2013-04-10 14:12 ` Pali Rohár [this message]
2013-04-10 17:00 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304101612.51620@pali \
--to=pali.rohar@gmail.com \
--cc=cbou@mail.ru \
--cc=j-keerthy@ti.com \
--cc=kyle@kylemanna.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).