From: Felipe Balbi <balbi@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Alexander Holler <holler@ahsoftware.de>,
balbi@ti.com, Greg KH <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] USB: ehci-omap: Select USB_PHY
Date: Thu, 11 Apr 2013 18:02:46 +0300 [thread overview]
Message-ID: <20130411150246.GR14394@arwen.pp.htv.fi> (raw)
In-Reply-To: <5166CC30.4060507@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]
Hi,
On Thu, Apr 11, 2013 at 05:44:00PM +0300, Roger Quadros wrote:
> Felipe,
>
> On 04/11/2013 04:02 PM, Alexander Holler wrote:
> > Am 11.04.2013 14:42, schrieb Roger Quadros:
> >> On 04/11/2013 01:55 PM, Felipe Balbi wrote:
> >
> >>> I would avoid 'select' completely and just update omap2plus_defconfig
> >>> adding those two as modules.
>
> Setting USB_PHY as a module gives rise to these problems
>
> arch/arm/mach-omap2/built-in.o: In function `usbhs_init_phys':
> /work/linux-2.6/arch/arm/mach-omap2/usb-host.c:652: undefined reference to `usb_bind_phy'
> arch/arm/mach-omap2/built-in.o: In function `omap_2430sdp_init':
> /work/linux-2.6/arch/arm/mach-omap2/board-2430sdp.c:236: undefined reference to `usb_bind_phy'
> arch/arm/mach-omap2/built-in.o: In function `omap3_beagle_init':
> /work/linux-2.6/arch/arm/mach-omap2/board-omap3beagle.c:554: undefined reference to `usb_bind_phy'
> arch/arm/mach-omap2/built-in.o: In function `devkit8000_init':
> /work/linux-2.6/arch/arm/mach-omap2/board-devkit8000.c:596: undefined reference to `usb_bind_phy'
> arch/arm/mach-omap2/built-in.o: In function `omap_ldp_init':
> /work/linux-2.6/arch/arm/mach-omap2/board-ldp.c:379: undefined reference to `usb_bind_phy'
>
> So USB_PHY shouldn't be tristate IMO or at least the platform registration stuff
> as the usb_bind_phy() part is used by platform code.
alright, let's send a patch to fix the check in the header. We should be
using IS_ENABLED() anyway.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-11 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 9:42 [PATCH] USB: ehci-omap: Select USB_PHY Roger Quadros
2013-04-11 10:04 ` Felipe Balbi
2013-04-11 10:51 ` Roger Quadros
2013-04-11 10:55 ` Felipe Balbi
2013-04-11 12:42 ` Roger Quadros
2013-04-11 13:02 ` Alexander Holler
2013-04-11 14:44 ` Roger Quadros
2013-04-11 15:02 ` Felipe Balbi [this message]
2013-04-11 17:33 ` Alexander Holler
2013-04-11 18:29 ` Felipe Balbi
2013-04-12 0:22 ` Alexander Holler
2013-04-11 13:18 ` Roger Quadros
[not found] ` <5166B829.1020304-l0cyMroinI0@public.gmane.org>
2013-04-11 14:34 ` Felipe Balbi
2013-04-11 14:53 ` Roger Quadros
2013-04-11 15:09 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411150246.GR14394@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=holler@ahsoftware.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox