linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL
@ 2013-05-16 13:29 Rob Herring
  2013-05-16 15:11 ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2013-05-16 13:29 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: Rob Herring, Tony Lindgren, linux-omap

From: Rob Herring <rob.herring@calxeda.com>

CONFIG_ARCH_OMAP2PLUS_TYPICAL is selecting user defined features, not h/w
required options. This does not play well with multi-platform kernels and
belongs in a defconfig.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
---
 arch/arm/mach-omap2/Kconfig | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index f49cd51..9d4b5f7 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -26,23 +26,6 @@ if ARCH_OMAP2PLUS
 
 menu "TI OMAP2/3/4 Specific Features"
 
-config ARCH_OMAP2PLUS_TYPICAL
-	bool "Typical OMAP configuration"
-	default y
-	select AEABI
-	select HIGHMEM
-	select I2C
-	select I2C_OMAP
-	select MENELAUS if ARCH_OMAP2
-	select NEON if ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5
-	select PM_RUNTIME
-	select REGULATOR
-	select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
-	select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
-	select VFP
-	help
-	  Compile a kernel suitable for booting most boards
-
 config SOC_HAS_OMAP2_SDRC
 	bool "OMAP2 SDRAM Controller support"
 
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL
  2013-05-16 13:29 [PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL Rob Herring
@ 2013-05-16 15:11 ` Tony Lindgren
  2013-05-16 15:19   ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2013-05-16 15:11 UTC (permalink / raw)
  To: Rob Herring; +Cc: linux-arm-kernel, Rob Herring, linux-omap

* Rob Herring <robherring2@gmail.com> [130516 06:34]:
> From: Rob Herring <rob.herring@calxeda.com>
> 
> CONFIG_ARCH_OMAP2PLUS_TYPICAL is selecting user defined features, not h/w
> required options. This does not play well with multi-platform kernels and
> belongs in a defconfig.

Yes we can remove this. But let's update omap2plus_defconfig with these
options where needed. I can update this patch for that and queue it
if that works for you.

Regards,

Tony


> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> ---
>  arch/arm/mach-omap2/Kconfig | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index f49cd51..9d4b5f7 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -26,23 +26,6 @@ if ARCH_OMAP2PLUS
>  
>  menu "TI OMAP2/3/4 Specific Features"
>  
> -config ARCH_OMAP2PLUS_TYPICAL
> -	bool "Typical OMAP configuration"
> -	default y
> -	select AEABI
> -	select HIGHMEM
> -	select I2C
> -	select I2C_OMAP
> -	select MENELAUS if ARCH_OMAP2
> -	select NEON if ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5
> -	select PM_RUNTIME
> -	select REGULATOR
> -	select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
> -	select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
> -	select VFP
> -	help
> -	  Compile a kernel suitable for booting most boards
> -
>  config SOC_HAS_OMAP2_SDRC
>  	bool "OMAP2 SDRAM Controller support"
>  
> -- 
> 1.8.1.2
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL
  2013-05-16 15:11 ` Tony Lindgren
@ 2013-05-16 15:19   ` Rob Herring
  2013-05-16 15:23     ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2013-05-16 15:19 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: linux-arm-kernel@lists.infradead.org, Rob Herring, linux-omap

On Thu, May 16, 2013 at 10:11 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Rob Herring <robherring2@gmail.com> [130516 06:34]:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> CONFIG_ARCH_OMAP2PLUS_TYPICAL is selecting user defined features, not h/w
>> required options. This does not play well with multi-platform kernels and
>> belongs in a defconfig.
>
> Yes we can remove this. But let's update omap2plus_defconfig with these
> options where needed. I can update this patch for that and queue it
> if that works for you.
>

Yes, that's fine. You might also want to enable the h/w related
features to multi_v7_defconfig as well.

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL
  2013-05-16 15:19   ` Rob Herring
@ 2013-05-16 15:23     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-05-16 15:23 UTC (permalink / raw)
  To: Rob Herring; +Cc: linux-arm-kernel@lists.infradead.org, Rob Herring, linux-omap

* Rob Herring <robherring2@gmail.com> [130516 08:25]:
> On Thu, May 16, 2013 at 10:11 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Rob Herring <robherring2@gmail.com> [130516 06:34]:
> >> From: Rob Herring <rob.herring@calxeda.com>
> >>
> >> CONFIG_ARCH_OMAP2PLUS_TYPICAL is selecting user defined features, not h/w
> >> required options. This does not play well with multi-platform kernels and
> >> belongs in a defconfig.
> >
> > Yes we can remove this. But let's update omap2plus_defconfig with these
> > options where needed. I can update this patch for that and queue it
> > if that works for you.
> >
> 
> Yes, that's fine. You might also want to enable the h/w related
> features to multi_v7_defconfig as well.

Yes will do. BTW, getting rid of CONFIG_ARCH_OMAP2PLUS_TYPICAL was the
reason I did not update multi_v7_defconfig yet.

I'll also update Arnd's randconfig fix patch and post it, then
will stick all three patches into one branch.

Regards,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-05-16 15:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-16 13:29 [PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL Rob Herring
2013-05-16 15:11 ` Tony Lindgren
2013-05-16 15:19   ` Rob Herring
2013-05-16 15:23     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).