linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP: fix __init section mismatch for _enable_preprogram
@ 2013-05-13  9:28 jean-philippe francois
  2013-05-16 18:04 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: jean-philippe francois @ 2013-05-13  9:28 UTC (permalink / raw)
  To: linux-omap@vger.kernel.org, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Hi,

_enable_preprogram is marked as __init, but is called from _enable
which is not. Without this patch, the board oopses after init. Tested
on custom hardware and on beagle board xM.

Signed-off-by: Jean-Philippe François <jp.francois@cynove.com>

[-- Attachment #2: omap_hwmod_fix.patch --]
[-- Type: application/octet-stream, Size: 494 bytes --]

Index: b/arch/arm/mach-omap2/omap_hwmod.c
===================================================================
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -2066,7 +2066,7 @@
  * do so is present in the hwmod data, then call it and pass along the
  * return value; otherwise, return 0.
  */
-static int __init _enable_preprogram(struct omap_hwmod *oh)
+static int _enable_preprogram(struct omap_hwmod *oh)
 {
 	if (!oh->class->enable_preprogram)
 		return 0;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: OMAP: fix __init section mismatch for _enable_preprogram
  2013-05-13  9:28 [PATCH] ARM: OMAP: fix __init section mismatch for _enable_preprogram jean-philippe francois
@ 2013-05-16 18:04 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2013-05-16 18:04 UTC (permalink / raw)
  To: jean-philippe francois; +Cc: linux-omap@vger.kernel.org, linux-arm-kernel

* jean-philippe francois <jp.francois@cynove.com> [130513 02:34]:
> Hi,
> 
> _enable_preprogram is marked as __init, but is called from _enable
> which is not. Without this patch, the board oopses after init. Tested
> on custom hardware and on beagle board xM.
> 
> Signed-off-by: Jean-Philippe François <jp.francois@cynove.com>

Thanks applying into omap-for-v3.10/fixes.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-16 18:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-13  9:28 [PATCH] ARM: OMAP: fix __init section mismatch for _enable_preprogram jean-philippe francois
2013-05-16 18:04 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).