From: Arnd Bergmann <arnd@arndb.de>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
avinashphilip@ti.com, tony@atomide.com, balbi@ti.com,
jp.francois@cynove.com
Subject: Re: [PATCH 4/4 v2] ARM: OMAP2+: updated ECC scheme attributes for omap2-nand DT
Date: Fri, 17 May 2013 14:46:05 +0200 [thread overview]
Message-ID: <201305171446.06023.arnd@arndb.de> (raw)
In-Reply-To: <1368791418-14330-5-git-send-email-pekon@ti.com>
On Friday 17 May 2013, Gupta, Pekon wrote:
> From: "Gupta, Pekon" <pekon@ti.com>
>
> Updates ECC scheme selection string same to same as used in omap2-driver code.
> This makes the DT configurations easy to understand and map to actual code.
>
> Signed-off-by: Gupta, Pekon <pekon@ti.com>
This moves the binding in the wrong direction. First of all, you should never
make incompatible changes to a specification document.
> - "bch8_hw_detection_sw" 8-bit BCH with ECC calculation in hardware
> - and error detection in software
> - - requires Kconfig CONFIG_MTD_NAND_ECC_BCH
The binding before your change is already broken since it refers to
Linux-specific Kconfig symbols, and you fail to fix that.
> + "OMAP_ECC_BCH4_CODE_HW_DETECTION_SW"
> + 4-bit BCH with ECC calculation in
> + hardware & error detection in software.
> + - requires CONFIG_MTD_NAND_ECC_BCH
Instead you make it worse by using /more/ Linux-isms in the binding.
Arnd
next prev parent reply other threads:[~2013-05-17 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 11:50 [PATCH 0/4 v2] mtd:nand:omap2: clean-up of supported ECC schemes Gupta, Pekon
2013-05-17 11:50 ` [PATCH 1/4 v2] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe Gupta, Pekon
2013-05-17 11:50 ` [PATCH 2/4 v2] ARM: OMAP2+: cleaned-up DT support of various ECC schemes Gupta, Pekon
2013-05-17 11:50 ` [PATCH 3/4 v2] mtd:nand:omap2: updated support for BCH4 ECC scheme Gupta, Pekon
2013-05-17 11:50 ` [PATCH 4/4 v2] ARM: OMAP2+: updated ECC scheme attributes for omap2-nand DT Gupta, Pekon
2013-05-17 12:46 ` Arnd Bergmann [this message]
2013-05-18 11:05 ` Gupta, Pekon
2013-05-24 13:01 ` [PATCH 0/4 v2] mtd:nand:omap2: clean-up of supported ECC schemes jean-philippe francois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305171446.06023.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=avinashphilip@ti.com \
--cc=balbi@ti.com \
--cc=jp.francois@cynove.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=pekon@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox