From: Tony Lindgren <tony@atomide.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jon Hunter <jon-hunter@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-omap@vger.kernel.org
Subject: Re: v3.10-rc1: backlight brightness after boot on N900
Date: Fri, 17 May 2013 11:45:35 -0700 [thread overview]
Message-ID: <20130517184534.GZ5600@atomide.com> (raw)
In-Reply-To: <20130517182504.GC31836@blackmetal.musicnaut.iki.fi>
* Aaro Koskinen <aaro.koskinen@iki.fi> [130517 11:30]:
> On Thu, May 16, 2013 at 07:52:12AM +0300, Tomi Valkeinen wrote:
> > On 15/05/13 20:18, Aaro Koskinen wrote:
> > > Is it expected that after boot you get 0 brightness i.e. a seemingly
> > > blank display on N900 with 3.10-rc1?
> >
> > There were some small changes merged in v3.10 related to acx's
> > backlight, but they were removing dead code so I don't see how those
> > could affect...
>
> [...]
>
> > So what comes to my mind is that either the model is detected wrong,
> > or the acx565akm_get_actual_brightness() which reads the current BL from
> > the panel happens to return 0, either because of an error, or because
> > the bootloader has set the BL to 0.
> >
> > But why either of those would've changed with v3.10... No idea...
>
> The panel is detected and probed correctly. So something else is wrong.
> It's not a bootloader issue, because booting 3.9 right after 3.10-rc1
> makes the display work again correctly.
>
> So I bisected and it points to:
>
> commit a2797beadfcb5a0974a30929b613b4d1adb023d1
> Author: Jon Hunter <jon-hunter@ti.com>
> Date: Thu Apr 4 15:16:15 2013 -0500
>
> gpio/omap: force restore if context loss is not detectable
>
> When I revert that commit from 3.10-rc1, the display works again as
> expected.
OK that should be fixed by ab6ec0fb (gpio/omap: ensure gpio context is initialised)
in linux-next. Can you check if that helps?
Looks like it has not yet been merged to mainline tree.
Linus W, any news on when you might be sending that fix upstream?
Regards,
Tony
next prev parent reply other threads:[~2013-05-17 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 17:18 v3.10-rc1: backlight brightness after boot on N900 Aaro Koskinen
2013-05-16 4:52 ` Tomi Valkeinen
2013-05-17 18:25 ` Aaro Koskinen
2013-05-17 18:45 ` Tony Lindgren [this message]
2013-05-17 19:17 ` Aaro Koskinen
2013-05-17 21:51 ` Linus Walleij
2013-05-17 22:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517184534.GZ5600@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=jon-hunter@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox