From: Graeme Gregory <gg@slimlogic.co.uk>
To: "J, KEERTHY" <j-keerthy@ti.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: Palmas: Introduce features to select the appropriate modules present in the palmas variant
Date: Fri, 14 Jun 2013 11:35:18 +0100 [thread overview]
Message-ID: <20130614103518.GH5456@mint> (raw)
In-Reply-To: <DC88CAD03C0052499C1907B327FC63229EBAAE@DBDE04.ent.ti.com>
On Fri, Jun 14, 2013 at 10:22:04AM +0000, J, KEERTHY wrote:
> Graeme/Laxman,
>
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Laxman Dewangan
> > Sent: Friday, June 14, 2013 3:32 PM
> > To: Graeme Gregory
> > Cc: J, KEERTHY; linux-omap@vger.kernel.org;
> > broonie@opensource.wolfsonmicro.com; sameo@linux.intel.com
> > Subject: Re: [PATCH] mfd: Palmas: Introduce features to select the
> > appropriate modules present in the palmas variant
> >
> > On Friday 14 June 2013 03:25 PM, Graeme Gregory wrote:
> > > On Fri, Jun 14, 2013 at 02:51:58PM +0530, J Keerthy wrote:
> > >> - children[PALMAS_PMIC_ID].platform_data = pdata->pmic_pdata;
> > >> - children[PALMAS_PMIC_ID].pdata_size = sizeof(*pdata->pmic_pdata);
> > >> + if (PALMAS_PMIC_HAS(palmas, REGULATORS)) {
> > >> + children[PALMAS_PMIC_ID].platform_data = pdata->pmic_pdata;
> > >> + children[PALMAS_PMIC_ID].pdata_size =
> > >> + sizeof(*pdata->pmic_pdata);
> > >> + }
> > >>
> > > I think a lot of complexity here could actually be removed by
> > removing
> > > the old board file style probing for palmas. I do not beleive either
> > > major user of palmas requires that anymore? I always had in my mind
> > > that this bit was temporary.
> >
> > Completely agree, we should not have this. Also this is not valid much
> > in DT context and so we can remove it.
>
> So shall I completely knock off the pdata assignments?
>
> BTW having features flag would still be handy for PMICs which might
> Not have all the features as TWL6035/Palmas. So I still want to retain
> That. Is it Okay?
>
Everything from the line
children = kmemdup(palmas_children, sizeof(palmas_children), GFP_KERNEL)
until error handling can go. As well as the palmas_children/palmas_ids
array at the top.
The features variable is I think superceded by DT, a feature not in chip
should not be in the DT. But if you have other technical reasons to keep
it I have no real strong opinion.
Graeme
prev parent reply other threads:[~2013-06-14 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:21 [PATCH] mfd: Palmas: Introduce features to select the appropriate modules present in the palmas variant J Keerthy
2013-06-14 9:55 ` Graeme Gregory
2013-06-14 10:02 ` Laxman Dewangan
2013-06-14 10:22 ` J, KEERTHY
2013-06-14 10:35 ` Graeme Gregory [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614103518.GH5456@mint \
--to=gg@slimlogic.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=j-keerthy@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).