linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Roger Quadros <rogerq@ti.com>,
	linux-omap <linux-omap@vger.kernel.org>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: OMAP4 Panda DVI problem
Date: Mon, 17 Jun 2013 04:35:47 -0700	[thread overview]
Message-ID: <20130617113546.GS20992@atomide.com> (raw)
In-Reply-To: <51BEF2BF.3000104@ti.com>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [130617 04:34]:
> On 17/06/13 14:18, Tony Lindgren wrote:
> 
> > You should be able to get the regulator based on the name just fine
> > from the drivers even if one driver is using DT and one is not. That is
> > as long as the regulator is defined. Then the regulator fwk will track
> > the usecount properly.
> 
> Doesn't the regulator need to be "bound" to a device for the driver to
> use the proper name for the regulator? I mean, in this case the dvi
> driver wants to get a regulator named "vdd_5v" (or something like that,
> I'm not sure what's the proper name). The USB host driver uses a name
> "vcc", while the real name of the regulator is "hsusbX_vcc".

I think that's for looking up regulators based on the dev entry, and also
name based lookup should work. But maybe I'm confusing it with the clock
framework. If you need to bind it to a device, you can do that too
dynamically I'd assume.

> If DVI driver wanted to use the regulator, it'd need to get
> "hsusbX_vcc". Which, I presume, would work, but is board specific and
> hacky, and it makes handling EPROBE_DEFER a bit more difficult.
> 
> Then again, maybe that's still simpler than making the regulator
> always-on, as there are complications with that approach also, which we
> are currently studying.
> 
> >>> So I think the simplest solution is to make DC_HST_5V always-on. This
> >>> should be fixed for 3.10 also.
> >>
> >> I am fine with this.
> > 
> > For a short term fix I'm fine with that, but please investigate using
> > the regulator, it might be simpler than you think.
> 
> I'll have a look, maybe there's something I'm missing.

Yes might be worth checking.

Regards,

Tony

  reply	other threads:[~2013-06-17 11:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 13:52 OMAP4 Panda DVI problem Tomi Valkeinen
2013-06-17  8:12 ` Roger Quadros
2013-06-17 11:18   ` Tony Lindgren
2013-06-17 11:27     ` Tomi Valkeinen
2013-06-17 11:35       ` Tony Lindgren [this message]
2013-06-17 11:37       ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130617113546.GS20992@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=rogerq@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).