Re: [PATCH] ARM: omap5: build opp4xxx_data.c

Nishanth Menon
2013-06-25T19:58:19Z

On 15:55-20130625, Santosh Shilimkar wrote:
> On Tuesday 25 June 2013 03:20 PM, Paul Walmsley wrote:
> > Santosh,
> >
> > On Fri, 21 Jun 2013, Nishanth Menon wrote:
> >
> >> /*
> >> * XXX Will depend on the process, validation, and binning
> >> * for the currently-running IC. Use OMAP4 data for time being.
> >> */
> >> #ifdef CONFIG_PM_OPP
> >> omap5_voltdm_mpu.volt_data = omap446x_vdd_mpu_volt_data;
> >> omap5_voltdm_mm.volt_data = omap446x_vdd_iva_volt_data;
> >> omap5_voltdm_core.volt_data = omap446x_vdd_core_volt_data;
> >> #endif
> >>
> >> Should we just remove this instead? these are obviously wrong.
> >
> > Are the OMAP4460 values expected to work and be safe for OMAP5, or not?
> > If the latter, please send a patch to remove them.
> >
> The plan was to update the data along with and VC OPP update
> for OMAP5 which Keerthy is working on. As such without VC code,
> this data is not doing anything so it is safe.
opp data in mach-omap2 is no longer used. everything is moving to dts
and OMAP5 is dts only. *IF* this is preventing boot, then we can hack
something in while we continue to debate on what we RFCs we have posted
so far.

Further, OPPs are NOT for Voltage Controller (VC). It is meant for
specific domains like MPU, SGX etc.. Having that data here, especially
wrong data is just plain wrong IMHO.

--
Regards,
Nishanth Menon