From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() Date: Wed, 26 Jun 2013 08:06:41 -0500 Message-ID: <20130626130641.GA26920@kahuna> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Wei Yongjun Cc: anton@enomsg.org, dwmw2@infradead.org, khilman@linaro.org, andrii.tseglytskyi@ti.com, jean.pihet@newoldbits.com, tony@atomide.com, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 09:57-20130626, Wei Yongjun wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun > --- > drivers/power/avs/smartreflex.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c > index db9973b..c26acfc 100644 > --- a/drivers/power/avs/smartreflex.c > +++ b/drivers/power/avs/smartreflex.c > @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sr_info->base = devm_ioremap_resource(&pdev->dev, mem); > - if (IS_ERR(sr_info->base)) { > - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); > + if (IS_ERR(sr_info->base)) > return PTR_ERR(sr_info->base); > - } > > irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > Acked-by: Nishanth Menon -- Regards, Nishanth Menon