From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@arm.linux.org.uk, eballetbo@gmail.com, javier@dowhile0.org,
gregkh@linuxfoundation.org, balbi@ti.com
Subject: Re: [PATCH 1/4] arm: omap: Add phy binding info for musb in plat data
Date: Thu, 4 Jul 2013 04:44:39 -0700 [thread overview]
Message-ID: <20130704114439.GA5523@atomide.com> (raw)
In-Reply-To: <1371631951-369-2-git-send-email-kishon@ti.com>
* Kishon Vijay Abraham I <kishon@ti.com> [130619 01:58]:
> In order for controllers to get PHY in case of non dt boot, the phy
> binding information (phy label) should be added in the platform
> data of the controller.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>
> Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> arch/arm/mach-omap2/usb-musb.c | 6 +++++-
> include/linux/usb/musb.h | 3 +++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 3242a55..5ddbe39 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -85,8 +85,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> musb_plat.mode = board_data->mode;
> musb_plat.extvbus = board_data->extvbus;
>
> - if (cpu_is_omap44xx())
> + if (cpu_is_omap44xx()) {
> musb_plat.has_mailbox = true;
> + musb_plat.phy_name = "omap-usb2";
> + } else if (cpu_is_omap34xx()) {
> + musb_plat.phy_name = "twl4030";
> + }
>
> if (soc_is_am35xx()) {
> oh_name = "am35x_otg_hs";
Care to refresh this patch against the current mainline tree?
Now omap4 is DT only, so this part won't apply. Mostly I'm wondering
what the phy_name should be for am35xx that's not covered by this
patch.
Also let me know if the last patch is safe to queue alone as a fix
or if it depends on the driver related changes in this series.
Regards,
Tony
next prev parent reply other threads:[~2013-07-04 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 8:52 [PATCH 0/4] usb: musb: fix USB enumeration issue in OMAP3 platform Kishon Vijay Abraham I
2013-06-19 8:52 ` [PATCH 1/4] arm: omap: Add phy binding info for musb in plat data Kishon Vijay Abraham I
2013-07-04 11:44 ` Tony Lindgren [this message]
2013-07-04 12:10 ` Kishon Vijay Abraham I
2013-06-19 8:52 ` [PATCH 2/4] usb: phy: add a new API to get PHY ref by label Kishon Vijay Abraham I
2013-06-19 8:52 ` [PATCH 3/4] usb: musb: omap: use the new API to get PHY reference " Kishon Vijay Abraham I
2013-06-19 8:52 ` [PATCH 4/4] arm: omap: remove using usb_bind_phy for binding musb and phy Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704114439.GA5523@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=eballetbo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@dowhile0.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).