Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well

[Ezequiel Garcia <ezequiel.garcia@free-electrons.com>]

Hi guys,

On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote:
> On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote:
> > From: Amarinder Bindra <a-bindra@ti.com>
> >
> > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation.
> > Considering that the device tree entries are already there for this,
> > allow the driver to be built when only OMAP5 is enabled.
> > This allows MMC root filesystems to be available in "OMAP5 only"
> > configurations.
> >
> > Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
> > Acked-by: Felipe Balbi <balbi@ti.com>
> > Acked-by: Nishanth Menon <nm@ti.com>
> 
> Looks good to me,
> Acked-by: Balaji T K <balajitk@ti.com>
> 

I came across this same issue while trying MMC patches on AM3xx,
which is nor OMAP3 neither OMAP4.

Now, looking at the driver I don't see any OMAP-specific bits
(welcome to the multiplatform world ;-) so I think we can just
remove the 'depends' line. Something like this:

---
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 9ab8f8d..bade7f2 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -273,10 +273,9 @@ config MMC_OMAP
 
 config MMC_OMAP_HS
 	tristate "TI OMAP High Speed Multimedia Card Interface support"
-	depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4
 	help
 	  This selects the TI OMAP High Speed Multimedia card Interface.
-	  If you have an OMAP2430 or OMAP3 board or OMAP4 board with a
+	  If you have an OMAP2430, OMAP3, OMAP4 or AM3xx board with a
 	  Multimedia Card slot, say Y or M here.
 
 	  If unsure, say N.

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com