Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
Date: Mon, 15 Jul 2013 17:26:05 +0100	[thread overview]
Message-ID: <20130715162605.GS11538@sirena.org.uk> (raw)
In-Reply-To: <20130715160045.GG32035@arwen.pp.htv.fi>

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On Mon, Jul 15, 2013 at 07:00:45PM +0300, Felipe Balbi wrote:
> On Mon, Jul 15, 2013 at 04:57:56PM +0100, Mark Brown wrote:
> > @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810

> >  config SND_OMAP_SOC_RX51
> >  	tristate "SoC Audio support for Nokia RX-51"
> > -	depends on SND_OMAP_SOC && MACH_NOKIA_RX51
> > +	depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)

> RX51 is OMAP3, and that's DT at all. This is likely just a case of
> updating commit log.

Sentence parse grammar not.

However...  if you look at the driver it actually does have DT support
in there, it checks for the machine type or for compatibility with n900.
Probably needs an ARM dependency which I'll add due to the machine type
check.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-07-15 16:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 15:57 [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms Mark Brown
2013-07-15 16:00 ` Felipe Balbi
2013-07-15 16:26   ` Mark Brown [this message]
2013-07-15 16:32     ` Felipe Balbi
2013-07-15 16:43 ` Peter Ujfalusi
2013-07-15 17:03   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130715162605.GS11538@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=balbi@ti.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox