linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Sebastian Andrzej Siewior
	<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: Ezequiel Garcia
	<elezegarcia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	george.cherian-l0cyMroinI0@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	b-cousson-l0cyMroinI0@public.gmane.org
Subject: Re: musb: dsps: make it work with two instances
Date: Wed, 17 Jul 2013 14:58:03 -0300	[thread overview]
Message-ID: <20130717175802.GD29791@localhost> (raw)
In-Reply-To: <20130717171229.GA1516-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>

Hi Sebastian,

On Wed, Jul 17, 2013 at 07:12:29PM +0200, Sebastian Andrzej Siewior wrote:
> 
> >After some minor DT tweaking on the current patchset,
> >I've managed to detect an USB mass storage device in the
> >second instance (host / usb1) using a Beaglebone black board.
> 
> Beaglebone black, that one has a different device tree which is not
> mainline, right?
> 

Beaglebone black it is. But I'm almost sure I just used the
am....bone.dts file that's mainlined.

I just changed the mode or something like that, very minor tweaking
indeed, altough right now I don't remember exactly which changes.

> >However, after I unplug the device, it's not recognized
> >when I replug it. Maybe you can take a look at this;
> >i'll do some more testings and see what I can come up with.
> 
> I figured out why my Host is not recognized on the second plug:
> At module load time, musb_start() is executed and it sets the
> MUSB_DEVCTL_SESSION in devctl.
> After the device is unplugged dsps_musb_try_idle() schedules a timer
> which executes the local otg_timer() function. Since the phy is in
> OTG_STATE_A_WAIT_BCON state, the MUSB_DEVCTL_SESSION bit gets removed.
> If the removal of the bit is ignored, the device is recognized after a
> re-plug.
> 

Mmmm... okey. Interesting insight, thanks!

> >Also, FWIW, I think that having a separate USB phy for am35xx would be
> >much better.
> So you would prefer a new file with 90% copy of what we already have in
> the nop_phy?
> 

No, of course not.

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2013-07-17 17:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 13:32 musb: dsps: make it work with two instances Sebastian Andrzej Siewior
2013-07-05 13:32 ` [PATCH 2/5] arm: dts: am33xx: add USB phy nodes Sebastian Andrzej Siewior
     [not found]   ` <1373031178-8871-3-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-05 14:41     ` Ruchika Kharwar
     [not found]       ` <51D6DB15.1050701-l0cyMroinI0@public.gmane.org>
2013-07-05 14:56         ` Sebastian Andrzej Siewior
2013-07-25 14:27           ` Felipe Balbi
2013-07-05 13:32 ` [PATCH 3/5] usb: musb: dsps: remove the hardcoded phy pieces Sebastian Andrzej Siewior
2013-07-25 14:28   ` Felipe Balbi
     [not found] ` <1373031178-8871-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-05 13:32   ` [PATCH 1/5] usb: phy: phy-nop: add support for am335x PHY Sebastian Andrzej Siewior
     [not found]     ` <1373031178-8871-2-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-25 14:24       ` Felipe Balbi
2013-07-05 13:32   ` [PATCH 4/5] usb: musb: dsps: use proper child nodes Sebastian Andrzej Siewior
2013-07-05 15:08     ` Enric Balletbo Serra
     [not found]       ` <CAFqH_529D9rEJJ2rk3jGm0aGt4ZXBpP=R3azAKUxyp9vA-Nf4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-05 15:15         ` Sebastian Andrzej Siewior
2013-07-05 15:22           ` Enric Balletbo Serra
2013-07-05 15:24             ` Sebastian Andrzej Siewior
2013-07-25 14:30     ` Felipe Balbi
2013-07-05 13:32   ` [PATCH 5/5] musb: musb: dsps: remove instances variable Sebastian Andrzej Siewior
2013-07-25 14:30     ` Felipe Balbi
2013-07-06 21:39   ` musb: dsps: make it work with two instances Ezequiel Garcia
     [not found]     ` <CALF0-+Vo64Znw_iY0gOx5hGJ9mgw7OXFQ5HqBrTW4udW-Z=N+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-08  8:28       ` Sebastian Andrzej Siewior
2013-07-17 17:12     ` Sebastian Andrzej Siewior
     [not found]       ` <20130717171229.GA1516-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-17 17:58         ` Ezequiel Garcia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717175802.GD29791@localhost \
    --to=ezequiel.garcia-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=b-cousson-l0cyMroinI0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=elezegarcia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=george.cherian-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).