From: Felipe Balbi <balbi@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Felipe Balbi <balbi@ti.com>,
george.cherian@ti.com, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org,
Benoit Cousson <benoit.cousson@linaro.org>
Subject: Re: [PATCH 3/5] usb: musb: dsps: remove the hardcoded phy pieces
Date: Thu, 25 Jul 2013 17:28:34 +0300 [thread overview]
Message-ID: <20130725142826.GF16106@radagast> (raw)
In-Reply-To: <1373031178-8871-4-git-send-email-bigeasy@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hi,
On Fri, Jul 05, 2013 at 03:32:56PM +0200, Sebastian Andrzej Siewior wrote:
> dsps uses a nop driver which is added in dsps itself and does the PHY
> on/off calls within dsps. Since those calls are now moved the nop driver
> itself, we can now request the phy proper phy and remove those calls.
> Currently only the first musb interface is used so we only add one phy
> node for now.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
looks good, just wondering if this won't pose a regression since you're
not substituting PHY handling with proper usb_phy_set_suspend() calls.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-25 14:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 13:32 musb: dsps: make it work with two instances Sebastian Andrzej Siewior
2013-07-05 13:32 ` [PATCH 2/5] arm: dts: am33xx: add USB phy nodes Sebastian Andrzej Siewior
[not found] ` <1373031178-8871-3-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-05 14:41 ` Ruchika Kharwar
[not found] ` <51D6DB15.1050701-l0cyMroinI0@public.gmane.org>
2013-07-05 14:56 ` Sebastian Andrzej Siewior
2013-07-25 14:27 ` Felipe Balbi
2013-07-05 13:32 ` [PATCH 3/5] usb: musb: dsps: remove the hardcoded phy pieces Sebastian Andrzej Siewior
2013-07-25 14:28 ` Felipe Balbi [this message]
[not found] ` <1373031178-8871-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-05 13:32 ` [PATCH 1/5] usb: phy: phy-nop: add support for am335x PHY Sebastian Andrzej Siewior
[not found] ` <1373031178-8871-2-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-25 14:24 ` Felipe Balbi
2013-07-05 13:32 ` [PATCH 4/5] usb: musb: dsps: use proper child nodes Sebastian Andrzej Siewior
2013-07-05 15:08 ` Enric Balletbo Serra
[not found] ` <CAFqH_529D9rEJJ2rk3jGm0aGt4ZXBpP=R3azAKUxyp9vA-Nf4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-05 15:15 ` Sebastian Andrzej Siewior
2013-07-05 15:22 ` Enric Balletbo Serra
2013-07-05 15:24 ` Sebastian Andrzej Siewior
2013-07-25 14:30 ` Felipe Balbi
2013-07-05 13:32 ` [PATCH 5/5] musb: musb: dsps: remove instances variable Sebastian Andrzej Siewior
2013-07-25 14:30 ` Felipe Balbi
2013-07-06 21:39 ` musb: dsps: make it work with two instances Ezequiel Garcia
[not found] ` <CALF0-+Vo64Znw_iY0gOx5hGJ9mgw7OXFQ5HqBrTW4udW-Z=N+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-08 8:28 ` Sebastian Andrzej Siewior
2013-07-17 17:12 ` Sebastian Andrzej Siewior
[not found] ` <20130717171229.GA1516-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-17 17:58 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725142826.GF16106@radagast \
--to=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=george.cherian@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).